Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2682)

Unified Diff: net/dns/host_resolver_impl.cc

Issue 761903003: Update from https://crrev.com/306655 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/dns/dns_transaction.cc ('k') | net/dns/single_request_host_resolver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/host_resolver_impl.cc
diff --git a/net/dns/host_resolver_impl.cc b/net/dns/host_resolver_impl.cc
index 9426da570238be4828ecd403f643bc06fa78eae4..b06a0065c90269dafb9a0e3c99cbfbc1754ff6a1 100644
--- a/net/dns/host_resolver_impl.cc
+++ b/net/dns/host_resolver_impl.cc
@@ -24,6 +24,7 @@
#include "base/message_loop/message_loop_proxy.h"
#include "base/metrics/field_trial.h"
#include "base/metrics/histogram.h"
+#include "base/profiler/scoped_tracker.h"
#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
@@ -480,6 +481,11 @@ class HostResolverImpl::Request {
// Prepare final AddressList and call completion callback.
void OnComplete(int error, const AddressList& addr_list) {
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/436634 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "436634 HostResolverImpl::Request::OnComplete"));
+
DCHECK(!was_canceled());
if (error == OK)
*addresses_ = EnsurePortOnAddressList(addr_list, info_.port());
@@ -679,6 +685,11 @@ class HostResolverImpl::ProcTask
const uint32 attempt_number,
int error,
const int os_error) {
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/436634 is fixed.
+ tracked_objects::ScopedTracker tracking_profile1(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "436634 HostResolverImpl::ProcTask::OnLookupComplete1"));
+
DCHECK(origin_loop_->BelongsToCurrentThread());
// If results are empty, we should return an error.
bool empty_list_on_ok = (error == OK && results.empty());
@@ -740,6 +751,11 @@ class HostResolverImpl::ProcTask
net_log_.EndEvent(NetLog::TYPE_HOST_RESOLVER_IMPL_PROC_TASK,
net_log_callback);
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/436634 is fixed.
+ tracked_objects::ScopedTracker tracking_profile2(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "436634 HostResolverImpl::ProcTask::OnLookupComplete2"));
+
callback_.Run(error, results_);
}
@@ -1470,6 +1486,11 @@ class HostResolverImpl::Job : public PrioritizedDispatcher::Job,
void OnProcTaskComplete(base::TimeTicks start_time,
int net_error,
const AddressList& addr_list) {
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/436634 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "436634 HostResolverImpl::Job::OnProcTaskComplete"));
+
DCHECK(is_proc_running());
if (!resolver_->resolved_known_ipv6_hostname_ &&
@@ -1619,6 +1640,11 @@ class HostResolverImpl::Job : public PrioritizedDispatcher::Job,
// Performs Job's last rites. Completes all Requests. Deletes this.
void CompleteRequests(const HostCache::Entry& entry,
base::TimeDelta ttl) {
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/436634 is fixed.
+ tracked_objects::ScopedTracker tracking_profile1(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "436634 HostResolverImpl::Job::CompleteRequests1"));
+
CHECK(resolver_.get());
// This job must be removed from resolver's |jobs_| now to make room for a
@@ -1668,6 +1694,11 @@ class HostResolverImpl::Job : public PrioritizedDispatcher::Job,
if (did_complete)
resolver_->CacheResult(key_, entry, ttl);
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/436634 is fixed.
+ tracked_objects::ScopedTracker tracking_profile2(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "436634 HostResolverImpl::Job::CompleteRequests2"));
+
// Complete all of the requests that were attached to the job.
for (RequestsList::const_iterator it = requests_.begin();
it != requests_.end(); ++it) {
« no previous file with comments | « net/dns/dns_transaction.cc ('k') | net/dns/single_request_host_resolver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698