base/win/scoped_comptr.h - Issue 761903003: Update from https://crrev.com/306655

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/win/scoped_comptr.h

Issue 761903003: Update from https://crrev.com/306655 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/win/scoped_comptr.h

diff --git a/base/win/scoped_comptr.h b/base/win/scoped_comptr.h

index 98cea0ff4c8a45f8612cdab90e7882d85b7e25c1..373c0c3ba50985bb83c4a93b3626def6601a9977 100644

--- a/base/win/scoped_comptr.h

+++ b/base/win/scoped_comptr.h

@@ -133,8 +133,7 @@ class ScopedComPtr : public scoped_refptr<Interface> {

ScopedComPtr<IUnknown> other_identity;

other->QueryInterface(other_identity.Receive());

- return static_cast<IUnknown*>(my_identity) ==

- static_cast<IUnknown*>(other_identity);

+ return my_identity == other_identity;

}

// Provides direct access to the interface.

« no previous file with comments | « base/win/pe_image.cc ('k') | build/all.gyp » ('j') | no next file with comments »