build/android/pylib/gtest/test_package_apk.py - Issue 761903003: Update from https://crrev.com/306655

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_apk.py

Issue 761903003: Update from https://crrev.com/306655 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/gtest/test_package_apk.py

diff --git a/build/android/pylib/gtest/test_package_apk.py b/build/android/pylib/gtest/test_package_apk.py

index 4a9127856731cc2df03f2dd4e69c1b95e5031910..67571a4a4f98e9149edda9a03bbaaebe9d81e5db 100644

--- a/build/android/pylib/gtest/test_package_apk.py

+++ b/build/android/pylib/gtest/test_package_apk.py

@@ -40,13 +40,8 @@ class TestPackageApk(TestPackage):

self._package_info = constants.PACKAGE_INFO['gtest']

def _CreateCommandLineFileOnDevice(self, device, options):

- command_line_file = tempfile.NamedTemporaryFile()

- # GTest expects argv[0] to be the executable path.

- command_line_file.write(self.suite_name + ' ' + options)

- command_line_file.flush()

- device.PushChangedFiles([(

- command_line_file.name,

- self._package_info.cmdline_file)])

+ device.WriteFile(self._package_info.cmdline_file,

+ self.suite_name + ' ' + options)

def _GetFifo(self):

# The test.fifo path is determined by: