Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: sandbox/linux/seccomp-bpf/errorcode_unittest.cc

Issue 761903003: Update from https://crrev.com/306655 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/linux/seccomp-bpf/errorcode.h ('k') | sandbox/linux/seccomp-bpf/sandbox_bpf.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/seccomp-bpf/errorcode_unittest.cc
diff --git a/sandbox/linux/seccomp-bpf/errorcode_unittest.cc b/sandbox/linux/seccomp-bpf/errorcode_unittest.cc
index ae68b0a57d036358f1c0eef83f65743eb9fdebb9..9f5090e3ae8504f9683b589fb819bcf9708d38c0 100644
--- a/sandbox/linux/seccomp-bpf/errorcode_unittest.cc
+++ b/sandbox/linux/seccomp-bpf/errorcode_unittest.cc
@@ -43,7 +43,7 @@ SANDBOX_TEST(ErrorCode, ErrnoConstructor) {
DummyPolicy dummy_policy;
bpf_dsl::PolicyCompiler compiler(&dummy_policy, Trap::Registry());
- ErrorCode e3 = compiler.Trap(NULL, NULL);
+ ErrorCode e3 = compiler.Trap(NULL, NULL, true /* safe */);
SANDBOX_ASSERT((e3.err() & SECCOMP_RET_ACTION) == SECCOMP_RET_TRAP);
uint16_t data = 0xdead;
@@ -61,12 +61,12 @@ SANDBOX_DEATH_TEST(ErrorCode,
SANDBOX_TEST(ErrorCode, Trap) {
DummyPolicy dummy_policy;
bpf_dsl::PolicyCompiler compiler(&dummy_policy, Trap::Registry());
- ErrorCode e0 = compiler.Trap(NULL, "a");
- ErrorCode e1 = compiler.Trap(NULL, "b");
+ ErrorCode e0 = compiler.Trap(NULL, "a", true /* safe */);
+ ErrorCode e1 = compiler.Trap(NULL, "b", true /* safe */);
SANDBOX_ASSERT((e0.err() & SECCOMP_RET_DATA) + 1 ==
(e1.err() & SECCOMP_RET_DATA));
- ErrorCode e2 = compiler.Trap(NULL, "a");
+ ErrorCode e2 = compiler.Trap(NULL, "a", true /* safe */);
SANDBOX_ASSERT((e0.err() & SECCOMP_RET_DATA) ==
(e2.err() & SECCOMP_RET_DATA));
}
@@ -83,9 +83,9 @@ SANDBOX_TEST(ErrorCode, Equals) {
DummyPolicy dummy_policy;
bpf_dsl::PolicyCompiler compiler(&dummy_policy, Trap::Registry());
- ErrorCode e4 = compiler.Trap(NULL, "a");
- ErrorCode e5 = compiler.Trap(NULL, "b");
- ErrorCode e6 = compiler.Trap(NULL, "a");
+ ErrorCode e4 = compiler.Trap(NULL, "a", true /* safe */);
+ ErrorCode e5 = compiler.Trap(NULL, "b", true /* safe */);
+ ErrorCode e6 = compiler.Trap(NULL, "a", true /* safe */);
SANDBOX_ASSERT(!e1.Equals(e4));
SANDBOX_ASSERT(!e3.Equals(e4));
SANDBOX_ASSERT(!e5.Equals(e4));
@@ -105,9 +105,9 @@ SANDBOX_TEST(ErrorCode, LessThan) {
DummyPolicy dummy_policy;
bpf_dsl::PolicyCompiler compiler(&dummy_policy, Trap::Registry());
- ErrorCode e4 = compiler.Trap(NULL, "a");
- ErrorCode e5 = compiler.Trap(NULL, "b");
- ErrorCode e6 = compiler.Trap(NULL, "a");
+ ErrorCode e4 = compiler.Trap(NULL, "a", true /* safe */);
+ ErrorCode e5 = compiler.Trap(NULL, "b", true /* safe */);
+ ErrorCode e6 = compiler.Trap(NULL, "a", true /* safe */);
SANDBOX_ASSERT(e1.LessThan(e4));
SANDBOX_ASSERT(e3.LessThan(e4));
SANDBOX_ASSERT(e4.LessThan(e5));
« no previous file with comments | « sandbox/linux/seccomp-bpf/errorcode.h ('k') | sandbox/linux/seccomp-bpf/sandbox_bpf.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698