Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: tools/valgrind/browser_wrapper_win.py

Issue 761903003: Update from https://crrev.com/306655 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/lsan/suppressions.txt ('k') | tools/valgrind/drmemory/suppressions.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import glob 5 import glob
6 import os 6 import os
7 import re 7 import re
8 import sys 8 import sys
9 import subprocess 9 import subprocess
10 10
11 # TODO(timurrrr): we may use it on POSIX too to avoid code duplication once we 11 # TODO(timurrrr): we may use it on POSIX too to avoid code duplication once we
12 # support layout_tests, remove Dr. Memory specific code and verify it works 12 # support layout_tests, remove Dr. Memory specific code and verify it works
13 # on a "clean" Mac. 13 # on a "clean" Mac.
14 14
15 testcase_name = None 15 testcase_name = None
16 for arg in sys.argv: 16 for arg in sys.argv:
17 m = re.match("\-\-gtest_filter=(.*)", arg) 17 m = re.match("\-\-gtest_filter=(.*)", arg)
18 if m: 18 if m:
19 assert testcase_name is None 19 assert testcase_name is None
20 testcase_name = m.groups()[0] 20 testcase_name = m.groups()[0]
21 21
22 # arg #0 is the path to this python script 22 # arg #0 is the path to this python script
23 cmd_to_run = sys.argv[1:] 23 cmd_to_run = sys.argv[1:]
24 24
25 # TODO(timurrrr): this is Dr. Memory-specific 25 # TODO(timurrrr): this is Dr. Memory-specific
26 # Usually, we pass "-logdir" "foo\bar\spam path" args to Dr. Memory. 26 # Usually, we pass "-logdir" "foo\bar\spam path" args to Dr. Memory.
27 # To group reports per UI test, we want to put the reports for each test into a 27 # To group reports per UI test, we want to put the reports for each test into a
28 # separate directory. This code can be simplified when we have 28 # separate directory. This code can be simplified when we have
29 # http://code.google.com/p/drmemory/issues/detail?id=684 fixed. 29 # https://github.com/DynamoRIO/drmemory/issues/684 fixed.
30 logdir_idx = cmd_to_run.index("-logdir") 30 logdir_idx = cmd_to_run.index("-logdir")
31 old_logdir = cmd_to_run[logdir_idx + 1] 31 old_logdir = cmd_to_run[logdir_idx + 1]
32 32
33 wrapper_pid = str(os.getpid()) 33 wrapper_pid = str(os.getpid())
34 34
35 # On Windows, there is a chance of PID collision. We avoid it by appending the 35 # On Windows, there is a chance of PID collision. We avoid it by appending the
36 # number of entries in the logdir at the end of wrapper_pid. 36 # number of entries in the logdir at the end of wrapper_pid.
37 # This number is monotonic and we can't have two simultaneously running wrappers 37 # This number is monotonic and we can't have two simultaneously running wrappers
38 # with the same PID. 38 # with the same PID.
39 wrapper_pid += "_%d" % len(glob.glob(old_logdir + "\\*")) 39 wrapper_pid += "_%d" % len(glob.glob(old_logdir + "\\*"))
40 40
41 cmd_to_run[logdir_idx + 1] += "\\testcase.%s.logs" % wrapper_pid 41 cmd_to_run[logdir_idx + 1] += "\\testcase.%s.logs" % wrapper_pid
42 os.makedirs(cmd_to_run[logdir_idx + 1]) 42 os.makedirs(cmd_to_run[logdir_idx + 1])
43 43
44 if testcase_name: 44 if testcase_name:
45 f = open(old_logdir + "\\testcase.%s.name" % wrapper_pid, "w") 45 f = open(old_logdir + "\\testcase.%s.name" % wrapper_pid, "w")
46 print >>f, testcase_name 46 print >>f, testcase_name
47 f.close() 47 f.close()
48 48
49 exit(subprocess.call(cmd_to_run)) 49 exit(subprocess.call(cmd_to_run))
OLDNEW
« no previous file with comments | « tools/lsan/suppressions.txt ('k') | tools/valgrind/drmemory/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698