Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_valuebuffer.cc

Issue 761903003: Update from https://crrev.com/306655 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "gpu/command_buffer/common/gles2_cmd_format.h" 8 #include "gpu/command_buffer/common/gles2_cmd_format.h"
9 #include "gpu/command_buffer/common/gles2_cmd_utils.h" 9 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
10 #include "gpu/command_buffer/service/gles2_cmd_decoder_unittest.h" 10 #include "gpu/command_buffer/service/gles2_cmd_decoder_unittest.h"
11
12 #include "gpu/command_buffer/service/test_helper.h" 11 #include "gpu/command_buffer/service/test_helper.h"
13 #include "gpu/command_buffer/service/valuebuffer_manager.h" 12 #include "gpu/command_buffer/service/valuebuffer_manager.h"
14 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
15 #include "ui/gl/gl_implementation.h" 14 #include "ui/gl/gl_implementation.h"
16 #include "ui/gl/gl_mock.h" 15 #include "ui/gl/gl_mock.h"
17 #include "ui/gl/gl_surface_stub.h" 16 #include "ui/gl/gl_surface_stub.h"
18 17
19 using ::gfx::MockGLInterface; 18 using ::gfx::MockGLInterface;
20 using ::testing::_; 19 using ::testing::_;
21 20
22 namespace gpu { 21 namespace gpu {
23 namespace gles2 { 22 namespace gles2 {
24 23
25 using namespace cmds; 24 using namespace cmds;
26 25
27 TEST_P(GLES2DecoderWithShaderTest, ValuebufferBasic) { 26 TEST_P(GLES2DecoderWithShaderTest, ValuebufferBasic) {
28 const uint32 kBufferId = 123; 27 const uint32 kBufferId = 123;
29 ValueState valuestate; 28 ValueState valuestate;
30 valuestate.int_value[0] = 111; 29 valuestate.int_value[0] = 111;
31 valuestate.int_value[1] = 222; 30 valuestate.int_value[1] = 222;
32 valuebuffer_manager()->CreateValuebuffer(kBufferId); 31 valuebuffer_manager()->CreateValuebuffer(kBufferId);
33 valuebuffer_manager()->UpdateValueState( 32 pending_valuebuffer_state()->UpdateState(
34 GL_MOUSE_POSITION_CHROMIUM, valuestate); 33 GL_MOUSE_POSITION_CHROMIUM, valuestate);
35 BindValuebufferCHROMIUM cmd1; 34 BindValuebufferCHROMIUM cmd1;
36 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId); 35 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId);
37 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1)); 36 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
38 SubscribeValueCHROMIUM cmd2; 37 SubscribeValueCHROMIUM cmd2;
39 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM); 38 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM);
40 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2)); 39 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
41 PopulateSubscribedValuesCHROMIUM cmd3; 40 PopulateSubscribedValuesCHROMIUM cmd3;
42 cmd3.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM); 41 cmd3.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM);
43 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3)); 42 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3));
44 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(1); 43 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(1);
45 UniformValuebufferCHROMIUM cmd4; 44 UniformValuebufferCHROMIUM cmd4;
46 cmd4.Init(kUniform2FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, 45 cmd4.Init(kUniform2FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM,
47 GL_MOUSE_POSITION_CHROMIUM); 46 GL_MOUSE_POSITION_CHROMIUM);
48 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd4)); 47 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd4));
49 } 48 }
50 49
51 TEST_P(GLES2DecoderWithShaderTest, SubscribeValuebufferNotBound) { 50 TEST_P(GLES2DecoderWithShaderTest, SubscribeValuebufferNotBound) {
52 const uint32 kBufferId = 123; 51 const uint32 kBufferId = 123;
53 ValueState valuestate; 52 ValueState valuestate;
54 valuestate.int_value[0] = 111; 53 valuestate.int_value[0] = 111;
55 valuestate.int_value[1] = 222; 54 valuestate.int_value[1] = 222;
56 valuebuffer_manager()->CreateValuebuffer(kBufferId); 55 valuebuffer_manager()->CreateValuebuffer(kBufferId);
57 valuebuffer_manager()->UpdateValueState( 56 pending_valuebuffer_state()->UpdateState(
58 GL_MOUSE_POSITION_CHROMIUM, valuestate); 57 GL_MOUSE_POSITION_CHROMIUM, valuestate);
59 SubscribeValueCHROMIUM cmd1; 58 SubscribeValueCHROMIUM cmd1;
60 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM); 59 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM);
61 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1)); 60 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
62 EXPECT_EQ(GL_INVALID_OPERATION, GetGLError()); 61 EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
63 } 62 }
64 63
65 TEST_P(GLES2DecoderWithShaderTest, PopulateValuebufferNoSubscription) { 64 TEST_P(GLES2DecoderWithShaderTest, PopulateValuebufferNoSubscription) {
66 const uint32 kBufferId = 123; 65 const uint32 kBufferId = 123;
67 ValueState valuestate; 66 ValueState valuestate;
68 valuestate.int_value[0] = 111; 67 valuestate.int_value[0] = 111;
69 valuestate.int_value[1] = 222; 68 valuestate.int_value[1] = 222;
70 valuebuffer_manager()->CreateValuebuffer(kBufferId); 69 valuebuffer_manager()->CreateValuebuffer(kBufferId);
71 valuebuffer_manager()->UpdateValueState( 70 pending_valuebuffer_state()->UpdateState(
72 GL_MOUSE_POSITION_CHROMIUM, valuestate); 71 GL_MOUSE_POSITION_CHROMIUM, valuestate);
73 BindValuebufferCHROMIUM cmd1; 72 BindValuebufferCHROMIUM cmd1;
74 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId); 73 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId);
75 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1)); 74 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
76 PopulateSubscribedValuesCHROMIUM cmd2; 75 PopulateSubscribedValuesCHROMIUM cmd2;
77 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM); 76 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM);
78 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2)); 77 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
79 EXPECT_EQ(GL_NONE, GetGLError()); 78 EXPECT_EQ(GL_NONE, GetGLError());
80 } 79 }
81 80
82 TEST_P(GLES2DecoderWithShaderTest, UniformValuebufferNoState) { 81 TEST_P(GLES2DecoderWithShaderTest, UniformValuebufferNoState) {
83 const uint32 kBufferId = 123; 82 const uint32 kBufferId = 123;
84 ValueState valuestate; 83 ValueState valuestate;
85 valuestate.int_value[0] = 111; 84 valuestate.int_value[0] = 111;
86 valuestate.int_value[1] = 222; 85 valuestate.int_value[1] = 222;
87 valuebuffer_manager()->CreateValuebuffer(kBufferId); 86 valuebuffer_manager()->CreateValuebuffer(kBufferId);
88 valuebuffer_manager()->UpdateValueState( 87 pending_valuebuffer_state()->UpdateState(
89 GL_MOUSE_POSITION_CHROMIUM, valuestate); 88 GL_MOUSE_POSITION_CHROMIUM, valuestate);
90 BindValuebufferCHROMIUM cmd1; 89 BindValuebufferCHROMIUM cmd1;
91 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId); 90 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId);
92 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1)); 91 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
93 SubscribeValueCHROMIUM cmd2; 92 SubscribeValueCHROMIUM cmd2;
94 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM); 93 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM);
95 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2)); 94 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
96 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(0); 95 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(0);
97 UniformValuebufferCHROMIUM cmd3; 96 UniformValuebufferCHROMIUM cmd3;
98 cmd3.Init(kUniform2FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, 97 cmd3.Init(kUniform2FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM,
99 GL_MOUSE_POSITION_CHROMIUM); 98 GL_MOUSE_POSITION_CHROMIUM);
100 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3)); 99 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3));
101 EXPECT_EQ(GL_NONE, GetGLError()); 100 EXPECT_EQ(GL_NONE, GetGLError());
102 } 101 }
103 102
104 TEST_P(GLES2DecoderWithShaderTest, UniformValuebufferInvalidLocation) { 103 TEST_P(GLES2DecoderWithShaderTest, UniformValuebufferInvalidLocation) {
105 const uint32 kBufferId = 123; 104 const uint32 kBufferId = 123;
106 ValueState valuestate; 105 ValueState valuestate;
107 valuestate.int_value[0] = 111; 106 valuestate.int_value[0] = 111;
108 valuestate.int_value[1] = 222; 107 valuestate.int_value[1] = 222;
109 valuebuffer_manager()->CreateValuebuffer(kBufferId); 108 valuebuffer_manager()->CreateValuebuffer(kBufferId);
110 valuebuffer_manager()->UpdateValueState( 109 pending_valuebuffer_state()->UpdateState(
111 GL_MOUSE_POSITION_CHROMIUM, valuestate); 110 GL_MOUSE_POSITION_CHROMIUM, valuestate);
112 BindValuebufferCHROMIUM cmd1; 111 BindValuebufferCHROMIUM cmd1;
113 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId); 112 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId);
114 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1)); 113 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
115 SubscribeValueCHROMIUM cmd2; 114 SubscribeValueCHROMIUM cmd2;
116 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM); 115 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM);
117 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2)); 116 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
118 PopulateSubscribedValuesCHROMIUM cmd3; 117 PopulateSubscribedValuesCHROMIUM cmd3;
119 cmd3.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM); 118 cmd3.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM);
120 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3)); 119 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3));
121 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(0); 120 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(0);
122 UniformValuebufferCHROMIUM cmd4; 121 UniformValuebufferCHROMIUM cmd4;
123 cmd4.Init(kUniform1FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, 122 cmd4.Init(kUniform1FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM,
124 GL_MOUSE_POSITION_CHROMIUM); 123 GL_MOUSE_POSITION_CHROMIUM);
125 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd4)); 124 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd4));
126 EXPECT_EQ(GL_INVALID_OPERATION, GetGLError()); 125 EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
127 } 126 }
128 127
129 } // namespace gles2 128 } // namespace gles2
130 } // namespace gpu 129 } // namespace gpu
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698