Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 761863007: [Telemetry] Fix NotImplementedError exceptions. (Closed)

Created:
6 years ago by slamm
Modified:
6 years ago
Reviewers:
nednguyen, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Raise NotImplementedError exceptions correctly. BUG=439346 Committed: https://crrev.com/e7cb2a354e20a4bb0aa1e427348e85e2486c9288 Cr-Commit-Position: refs/heads/master@{#307055}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Lint and reorder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M tools/telemetry/telemetry/core/backends/android_app_backend.py View 1 1 chunk +19 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/app_backend.py View 1 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
slamm
Chris suggested breaking this out from https://codereview.chromium.org/776883004/.
6 years ago (2014-12-05 17:47:19 UTC) #2
chrishenry
lgtm
6 years ago (2014-12-05 17:50:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761863007/1
6 years ago (2014-12-05 17:51:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/28489)
6 years ago (2014-12-05 17:57:08 UTC) #7
chrishenry
Well, that's a bummer, can you also fix the lint failure (add empty methods to ...
6 years ago (2014-12-05 18:03:55 UTC) #8
slamm
Lint and reorder
6 years ago (2014-12-05 18:17:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761863007/20001
6 years ago (2014-12-05 18:18:44 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-05 19:18:23 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-05 19:19:14 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7cb2a354e20a4bb0aa1e427348e85e2486c9288
Cr-Commit-Position: refs/heads/master@{#307055}

Powered by Google App Engine
This is Rietveld 408576698