Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist.html

Issue 761773002: MSE: Remove "item" indexed property getter from SourceBufferList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist.html
diff --git a/LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist.html b/LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist.html
index b8bd9d762f57ff0285e6d30d489eaf8b4da8df1e..e2d8c49bb2fce314ee3dca14631c2d0066d71bed 100644
--- a/LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist.html
+++ b/LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist.html
@@ -112,6 +112,27 @@
test.done();
});
}, "Test removesourcebuffer event firing on sourceBuffers and activeSourceBuffers when MediaSource closes.", { allow_media_element_error: true } );
+
+ mediasource_testafterdataloaded(function(test, mediaElement, mediaSource, segmentInfo, sourceBuffer, mediaData)
+ {
+ // Basic checks
+ assert_equals(mediaSource.sourceBuffers.length, 1, "mediaSource sourceBuffers length");
+ assert_equals(mediaSource.sourceBuffers[0], sourceBuffer, "matching sourceBuffer");
+ assert_not_equals(undefined, null, "null is different from undefined");
philipj_slow 2014/11/26 18:52:34 A bit paranoid, but OK :)
+
+ // SourceBufferList's indexed property getter is anonymous. At least ensure no 'item' is defined.
+ assert_equals(mediaSource.sourceBuffers.item, undefined, "'item' is undefined for MediaSource.sourceBuffers");
+
+ // Out-of-range indices should result in undefined.
+ assert_equals(mediaSource.sourceBuffers[1], undefined, "undefined result for out-of-range (+1 index)");
+ assert_equals(mediaSource.sourceBuffers[2], undefined, "undefined result for out-of-range (+2 index)");
+ assert_equals(mediaSource.sourceBuffers[undefined], undefined, "undefined result for out-of-range (undefined index)")
+ assert_equals(mediaSource.sourceBuffers[null], undefined, "undefined result for out-of-range (null index)");
+ assert_equals(mediaSource.sourceBuffers[""], undefined, "undefined result for out-of-range (empty string index)");
+ assert_equals(mediaSource.sourceBuffers["invalid index"], undefined, "undefined result for out-of-range (string index)");
+
+ test.done();
+ }, "Test out-of-range SourceBufferList indexed property getter behavior");
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698