MSE: Remove "item" indexed property getter from SourceBufferList

MSE: Remove "item" indexed property getter from SourceBufferList

The MSE spec only has an anonymous indexed property getter for
SourceBufferList, but we previously had an IDL method called "item"
exposed. This CL removes that non-compliant method and also adds test
coverage for out-of-range index for SourceBufferList indexed property
getter behavior to help confirm correctness of implementation and
bindings.

R=philipj@opera.com
BUG=436963
TEST=http/tests/media/media-source/mediasource-sourcebufferlist.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186058

[wolenetz, 2014-11-26 18:24:57]

wolenetz@chromium.org changed reviewers:
+ philipj@opera.com
- philipj@chromium.org

[wolenetz, 2014-11-26 18:27:40]

Please take a look at patch set 1.
Note, prior to changing the idl, the new layout test case failed (see below),
further increasing confidence that the behavior and bindings are compliant with
MSE spec:

"FAIL Test out-of-range SourceBufferList indexed property getter behavior
assert_equals: 'item' is undefined for MediaSource.sourceBuffers expected
(undefined) undefined but got (function) function "function item() { [native
code] }"

[philipj_slow, 2014-11-26 18:52:35]

LGTM, thanks!

https://codereview.chromium.org/761773002/diff/1/LayoutTests/http/tests/media...
File LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist.html
(right):

https://codereview.chromium.org/761773002/diff/1/LayoutTests/http/tests/media...
LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist.html:121:
assert_not_equals(undefined, null, "null is different from undefined");
A bit paranoid, but OK :)

https://codereview.chromium.org/761773002/diff/1/Source/modules/mediasource/S...
File Source/modules/mediasource/SourceBufferList.idl (right):

https://codereview.chromium.org/761773002/diff/1/Source/modules/mediasource/S...
Source/modules/mediasource/SourceBufferList.idl:37: [ImplementedAs=item] getter
SourceBuffer (unsigned long index);
Ah, I've seen this before but failed to realize it was to make the getter
anonymous :)

[wolenetz, 2014-11-26 19:25:28]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2014-11-26 19:25:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/761773002/1

[wolenetz, 2014-11-26 19:26:10]

On 2014/11/26 18:52:35, philipj wrote:
> LGTM, thanks!
> 
>
https://codereview.chromium.org/761773002/diff/1/LayoutTests/http/tests/media...
> File
LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist.html
> (right):
> 
>
https://codereview.chromium.org/761773002/diff/1/LayoutTests/http/tests/media...
>
LayoutTests/http/tests/media/media-source/mediasource-sourcebufferlist.html:121:
> assert_not_equals(undefined, null, "null is different from undefined");
> A bit paranoid, but OK :)
> 
>
https://codereview.chromium.org/761773002/diff/1/Source/modules/mediasource/S...
> File Source/modules/mediasource/SourceBufferList.idl (right):
> 
>
https://codereview.chromium.org/761773002/diff/1/Source/modules/mediasource/S...
> Source/modules/mediasource/SourceBufferList.idl:37: [ImplementedAs=item]
getter
> SourceBuffer (unsigned long index);
> Ah, I've seen this before but failed to realize it was to make the getter
> anonymous :)

Thank you for review. I am paranoid sometimes :) (protecting assumption borders
locally, in this case...)

[commit-bot: I haz the power, 2014-11-26 21:34:25]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186058