Source/core/page/CustomContextMenuProvider.cpp - Issue 761743002: Implement disabled and checked attribute for menuitem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/CustomContextMenuProvider.cpp

Issue 761743002: Implement disabled and checked attribute for menuitem. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: "disabled" only Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/CustomContextMenuProvider.cpp

diff --git a/Source/core/page/CustomContextMenuProvider.cpp b/Source/core/page/CustomContextMenuProvider.cpp

index 9db64393d6caf567604c153a5e0be2b83e855e9b..3b1ca8f6061983eca0ef3be686460571f3104927 100644

--- a/Source/core/page/CustomContextMenuProvider.cpp

+++ b/Source/core/page/CustomContextMenuProvider.cpp

@@ -80,7 +80,7 @@ void CustomContextMenuProvider::appendMenuItem(HTMLMenuItemElement* menuItem, Co

return;

m_menuItems.append(menuItem);

- contextMenu.appendItem(ContextMenuItem(ActionType, static_cast<ContextMenuAction>(ContextMenuItemBaseCustomTag + m_menuItems.size() - 1), labelString));

+ contextMenu.appendItem(ContextMenuItem(ActionType, static_cast<ContextMenuAction>(ContextMenuItemBaseCustomTag + m_menuItems.size() - 1), labelString, !menuItem->fastHasAttribute(disabledAttr), false));

}

void CustomContextMenuProvider::populateContextMenuItems(const HTMLMenuElement& menu, ContextMenu& contextMenu)

« no previous file with comments | « LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu-expected.txt ('k') | no next file » | no next file with comments »