Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 761723002: AccessibilityTabModelWrapper should call notifyDataSetChanged() when newTab is created (Closed)

Created:
6 years ago by patro
Modified:
6 years ago
CC:
chromium-reviews, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, plundblad+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

AccessibilityTabModelWrapper should call notifyDataSetChanged() when newTab is created ChromeShellTabModelSelector should notify the listeners when a new tab is created. And ChangeListeners must not be deregistered when TabManager is detached from window because new tab can also be created when the TabManager is detached. BUG=436824 Committed: https://crrev.com/9548243fca6a3524694de5683a4486d70837d968 Cr-Commit-Position: refs/heads/master@{#305840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTabModelSelector.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
patro
Kindly Review Thanks Shyam Patro
6 years ago (2014-11-26 10:35:33 UTC) #1
patro
Kindly Review Thanks Shyam Patro
6 years ago (2014-11-26 10:36:09 UTC) #3
David Trainor- moved to gerrit
lgtm
6 years ago (2014-11-26 17:49:53 UTC) #5
dmazzoni
Seems right, but dtrainor is a better reviewer for this. +clholgat as FYI
6 years ago (2014-11-26 17:53:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761723002/1
6 years ago (2014-11-26 17:54:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-26 18:34:45 UTC) #10
commit-bot: I haz the power
6 years ago (2014-11-26 18:35:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9548243fca6a3524694de5683a4486d70837d968
Cr-Commit-Position: refs/heads/master@{#305840}

Powered by Google App Engine
This is Rietveld 408576698