Issue 761673004: Start immediate dominator propagation at entry to floating control.

Issue 761673004: Start immediate dominator propagation at entry to floating control. (Closed)

Created:
6 years ago by Michael Starzinger

Modified:
6 years ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Start immediate dominator propagation at entry to floating control. R=titzer@chromium.org

Patch Set 2 : Addressed comments. #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -13 lines)			Patch
	M	src/compiler/scheduler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/compiler/scheduler.cc	View	1	3 chunks	+17 lines, -13 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

titzer

lgtm https://codereview.chromium.org/761673004/diff/1/src/compiler/scheduler.cc File src/compiler/scheduler.cc (right): https://codereview.chromium.org/761673004/diff/1/src/compiler/scheduler.cc#newcode1040 src/compiler/scheduler.cc:1040: // TODO(danno): Consider using Lengauer & Tarjan's if ...

6 years ago (2014-11-27 10:59:59 UTC) #2

Michael Starzinger

https://codereview.chromium.org/761673004/diff/1/src/compiler/scheduler.cc File src/compiler/scheduler.cc (right): https://codereview.chromium.org/761673004/diff/1/src/compiler/scheduler.cc#newcode1040 src/compiler/scheduler.cc:1040: // TODO(danno): Consider using Lengauer & Tarjan's if this ...

6 years ago (2014-11-27 11:29:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761673004/20001

6 years ago (2014-11-27 11:33:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages