Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 761663004: Allow to get key from SPAKE2 after the first round trip. (Closed)

Created:
6 years ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow to get key from SPAKE2 after the first round trip. The second round trip is optional and is not the part of SPAKE2 algorithm. Application may want to get key and do verification with usefull payload. BUG=438470 R=agl@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/fb2ccf63152e415e5bb1243b1284ef496cf45c03

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M crypto/p224_spake.h View 1 chunk +5 lines, -1 line 0 comments Download
M crypto/p224_spake.cc View 1 chunk +9 lines, -1 line 0 comments Download
M crypto/p224_spake_unittest.cc View 1 4 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Vitaly Buka (NO REVIEWS)
Please review.
6 years ago (2014-12-04 02:12:45 UTC) #3
agl
lgtm
6 years ago (2014-12-04 02:29:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761663004/20001
6 years ago (2014-12-04 08:08:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/28171)
6 years ago (2014-12-04 08:11:59 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fb2ccf63152e415e5bb1243b1284ef496cf45c03 Cr-Commit-Position: refs/heads/master@{#306844}
6 years ago (2014-12-04 17:18:08 UTC) #11
Vitaly Buka (NO REVIEWS)
6 years ago (2014-12-04 17:18:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as fb2ccf6.

Powered by Google App Engine
This is Rietveld 408576698