Issue 761593006: Do circle anti-aliasing in normalized space to avoid precision issues with half-floats on Adreno.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 761593006: Do circle anti-aliasing in normalized space to avoid precision issues with half-floats on Adreno. (Closed)

Created:
6 years ago by bsalomon

Modified:
6 years ago

Reviewers:
jvanverth1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Do circle anti-aliasing in normalized space to avoid precision issues with half-floats on Adreno. Committed: https://skia.googlesource.com/skia/+/ce1c8869cf5e37753f9c8193314d93bff897d014

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -24 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	gm/circles.cpp	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/gpu/GrOvalRenderer.cpp	View	1	7 chunks	+30 lines, -24 lines	0 comments	Download

Total messages: 7 (2 generated)

jvanverth1

LGTM. Is this not an issue with ellipses because they're already normalized?

6 years ago (2014-12-11 14:23:42 UTC) #3

bsalomon

On 2014/12/11 14:23:42, jvanverth1 wrote: > LGTM. > > Is this not an issue with ...

6 years ago (2014-12-11 15:09:28 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761593006/40001

6 years ago (2014-12-15 15:03:28 UTC) #6

commit-bot: I haz the power

6 years ago (2014-12-15 15:11:26 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ce1c8869cf5e37753f9c8193314d93bff897d014