Issue 761573002: Make mojob.py use mopy.config.Config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 761573002: Make mojob.py use mopy.config.Config. (Closed)

Created:
6 years ago by viettrungluu

Modified:
6 years ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make mojob.py use mopy.config.Config. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/24e7e7a8e490e3b3d258c1e2a41df1aabb60ab24

Patch Set 2 : delete _GetIsClang #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -65 lines)			Patch
	M	mojo/tools/mojob.py	View		11 chunks	+90 lines, -60 lines	0 comments	Download
	M	mojo/tools/mopy/config.py	View	1	2 chunks	+20 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/761573002/diff/1/mojo/tools/mojob.py File mojo/tools/mojob.py (right): https://codereview.chromium.org/761573002/diff/1/mojo/tools/mojob.py#newcode36 mojo/tools/mojob.py:36: additional_args['is_clang'] = (target_os not in (Config.OS_ANDROID, why do ...

6 years ago (2014-11-25 18:56:08 UTC) #2

viettrungluu

On 2014/11/25 18:56:08, jamesr wrote: > lgtm > > https://codereview.chromium.org/761573002/diff/1/mojo/tools/mojob.py > File mojo/tools/mojob.py (right): > ...

6 years ago (2014-11-25 18:59:45 UTC) #3

viettrungluu

6 years ago (2014-11-25 19:06:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
24e7e7a8e490e3b3d258c1e2a41df1aabb60ab24 (presubmit successful).

Expand Messages | Collapse Messages

Issue 761573002: Make mojob.py use mopy.config.Config. (Closed)

Description

Patch Set 1 #

Patch Set 2 : delete _GetIsClang #

Messages