Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: src/gpu/GrDefaultGeoProcFactory.h

Issue 761563002: First step to moving vertex attributes to the geometryProcessor (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: adding test to ignore Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrContext.cpp ('k') | src/gpu/GrDefaultGeoProcFactory.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrDefaultGeoProcFactory.h
diff --git a/src/gpu/GrDefaultGeoProcFactory.h b/src/gpu/GrDefaultGeoProcFactory.h
index 99d85b64d634b08ba2aa9be67ebf48ac589251fd..a39c76da199dcf63ae81d19ca2803634af6493fa 100644
--- a/src/gpu/GrDefaultGeoProcFactory.h
+++ b/src/gpu/GrDefaultGeoProcFactory.h
@@ -17,8 +17,6 @@ class GrDrawState;
* view matrix and wire through color, coverage, UV coords if requested. Right now this is only
* used in the creation of optimized draw states because adding default GPs to the drawstate can
* interfere with batching due to updating the drawstate.
- * TODO When we track geometry state separately from the draw state, we should be able use a default
- * GP with every draw call
*/
class GrDefaultGeoProcFactory {
public:
@@ -82,9 +80,7 @@ public:
*
* You must unref the return from Create.
*/
- static void SetAttribs(GrDrawState*, uint32_t GPTypeFlags = 0);
- static const GrGeometryProcessor* CreateAndSetAttribs(GrDrawState*, uint32_t GPTypeFlags = 0);
- static const GrGeometryProcessor* Create(bool hasAttributeCoverage);
+ static const GrGeometryProcessor* Create(uint32_t gpTypeFlags = 0);
};
#endif
« no previous file with comments | « src/gpu/GrContext.cpp ('k') | src/gpu/GrDefaultGeoProcFactory.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698