gm/convexpolyeffect.cpp - Issue 761563002: First step to moving vertex attributes to the geometryProcessor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/convexpolyeffect.cpp

Issue 761563002: First step to moving vertex attributes to the geometryProcessor (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: feedback incorporated Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/convexpolyeffect.cpp

diff --git a/gm/convexpolyeffect.cpp b/gm/convexpolyeffect.cpp

index 8ee4a5db6f1312e04fa310d9d2333e492a9977cd..1e5c6017ca93e38ff1dc9532d4ca56083b68853f 100644

--- a/gm/convexpolyeffect.cpp

+++ b/gm/convexpolyeffect.cpp

@@ -133,13 +133,15 @@ protected:

}

GrDrawState ds;

- ds.setGeometryProcessor(GrDefaultGeoProcFactory::Create(false))->unref();

+ const GrGeometryProcessor* gp = GrDefaultGeoProcFactory::Create();

+ ds.setGeometryProcessor(gp)->unref();

ds.addCoverageProcessor(fp);

ds.setIdentityViewMatrix();

ds.setRenderTarget(rt);

ds.setColor(0xff000000);

- GrDrawTarget::AutoReleaseGeometry geo(tt.target(), 4, ds.getVertexStride(), 0);

+ GrDrawTarget::AutoReleaseGeometry geo(tt.target(), 4, gp->getVertexStride(), 0);

+ SkASSERT(gp->getVertexStride() == sizeof(SkPoint));

SkPoint* verts = reinterpret_cast<SkPoint*>(geo.vertices());

SkRect bounds = p.getBounds();

@@ -189,13 +191,15 @@ protected:

}