Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: src/gpu/GrDefaultPathRenderer.cpp

Issue 761563002: First step to moving vertex attributes to the geometryProcessor (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase and small cleanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/GrDefaultPathRenderer.cpp
diff --git a/src/gpu/GrDefaultPathRenderer.cpp b/src/gpu/GrDefaultPathRenderer.cpp
index 3b31e876a236af01ce4ed793e8a6203caa987847..39cda730f24b22bc4f73ae836376995602d4eec8 100644
--- a/src/gpu/GrDefaultPathRenderer.cpp
+++ b/src/gpu/GrDefaultPathRenderer.cpp
@@ -233,8 +233,9 @@ bool GrDefaultPathRenderer::createGeom(GrDrawTarget* target,
}
}
- drawState->setDefaultVertexAttribs();
- if (!arg->set(target, maxPts, drawState->getVertexStride(), maxIdxs)) {
+ // TODO this is really wierd, I just need default vertex stride, can I think of a better way?
+ SkAutoTUnref<const GrGeometryProcessor> gp(GrDefaultGeoProcFactory::Create());
+ if (!arg->set(target, maxPts, gp->getVertexStride(), maxIdxs)) {
return false;
}
@@ -497,7 +498,7 @@ bool GrDefaultPathRenderer::internalDrawPath(GrDrawTarget* target,
drawState->enableState(GrDrawState::kNoColorWrites_StateBit);
}
GrDrawState::AutoRestoreEffects are(drawState);
- drawState->setGeometryProcessor(GrDefaultGeoProcFactory::Create(false))->unref();
+ drawState->setGeometryProcessor(GrDefaultGeoProcFactory::Create())->unref();
if (indexCnt) {
target->drawIndexed(drawState,
primType,

Powered by Google App Engine
This is Rietveld 408576698