Issue 761553003: Add validation tests to python bindings.

Issue 761553003: Add validation tests to python bindings. (Closed)

Created:
6 years ago by qsr

Modified:
6 years ago

Reviewers:
sdefresne

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add validation tests to python bindings. R=sdefresne@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/34edc09e4e09bfded3fc2b5266f8d59105948521

Patch Set 2 : Refactor handles in the context #

Total comments: 4

Patch Set 3 : Follow review #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+301 lines, -57 lines)			Patch
M	mojo/public/python/mojo/bindings/descriptor.py	View	1 2	17 chunks	+61 lines, -37 lines	0 comments	Download
M	mojo/public/python/mojo/bindings/reflection.py	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	mojo/public/python/mojo/bindings/serialization.py	View	1 2	2 chunks	+73 lines, -6 lines	0 comments	Download
M	mojo/python/BUILD.gn	View		2 chunks	+23 lines, -0 lines	0 comments	Download
A +	mojo/python/system/mojo/tests/__init__.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	mojo/python/system/mojo/tests/validation_util.pyx	View		1 chunk	+35 lines, -0 lines	0 comments	Download
M	mojo/python/tests/bindings_serialization_deserialization_unittest.py	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	mojo/python/tests/mojo_unittest.py	View	1	1 chunk	+11 lines, -7 lines	0 comments	Download
A	mojo/python/tests/validation_unittest.py	View		1 chunk	+85 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sdefresne

lgtm https://codereview.chromium.org/761553003/diff/20001/mojo/public/python/mojo/bindings/descriptor.py File mojo/public/python/mojo/bindings/descriptor.py (right): https://codereview.chromium.org/761553003/diff/20001/mojo/public/python/mojo/bindings/descriptor.py#newcode378 mojo/public/python/mojo/bindings/descriptor.py:378: return (nb_elements + 7) / 8 nit: return ...

6 years ago (2014-11-28 14:26:24 UTC) #2

qsr

https://codereview.chromium.org/761553003/diff/20001/mojo/public/python/mojo/bindings/descriptor.py File mojo/public/python/mojo/bindings/descriptor.py (right): https://codereview.chromium.org/761553003/diff/20001/mojo/public/python/mojo/bindings/descriptor.py#newcode378 mojo/public/python/mojo/bindings/descriptor.py:378: return (nb_elements + 7) / 8 On 2014/11/28 14:26:24, ...

6 years ago (2014-11-28 14:30:54 UTC) #3

qsr

6 years ago (2014-11-28 14:32:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
34edc09e4e09bfded3fc2b5266f8d59105948521 (presubmit successful).

Expand Messages | Collapse Messages