Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 761223002: IDL: Add error handlings to avoid infinite loops (Closed)

Created:
6 years ago by bashi
Modified:
6 years ago
Reviewers:
haraken, noelallen1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

IDL: Add error handlings to avoid infinite loops The IDL parser lacks some error propagation rules, which cause infinite loops when an IDL file contains syntax errors. This CL fixes following two cases: (1) Missing arguments: interface I { void foo(DOMString arg, ); }; (2) Unexpected "attribute" in dictionary dictionary D { attribute DOMString member = ""; }; BUG=435794 Committed: https://crrev.com/d54ddee89897d16b1611a7dc80c8eb4aed81b422 Cr-Commit-Position: refs/heads/master@{#306049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M tools/idl_parser/idl_parser.py View 2 chunks +11 lines, -0 lines 0 comments Download
M tools/idl_parser/test_parser/dictionary_web.idl View 1 chunk +4 lines, -1 line 0 comments Download
M tools/idl_parser/test_parser/interface_web.idl View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bashi
PTAL?
6 years ago (2014-11-28 01:19:14 UTC) #2
haraken
LGTM
6 years ago (2014-11-28 01:36:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761223002/1
6 years ago (2014-11-28 05:19:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-28 05:58:10 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-28 05:58:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d54ddee89897d16b1611a7dc80c8eb4aed81b422
Cr-Commit-Position: refs/heads/master@{#306049}

Powered by Google App Engine
This is Rietveld 408576698