Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 761113003: Make Document.inputEncoding an explicit alias of Document.characterSet (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
CC:
blink-reviews, tyoshino+watch_chromium.org, arv+blink, gavinp+loader_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, Nate Chapin, rwlbuis
Project:
blink
Visibility:
Public.

Description

Make Document.inputEncoding an explicit alias of Document.characterSet Document.inputEncoding has been revived in the DOM Standard: https://www.w3.org/Bugs/Public/show_bug.cgi?id=27435 https://dom.spec.whatwg.org/#document Drop the FIXME in XMLHttpRequest::send, as per spec the charset should always be UTF-8: https://xhr.spec.whatwg.org/#the-send()-method This is internal refactoring; no observable change intended. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186333

Patch Set 1 #

Patch Set 2 : drop FIXME #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M Source/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FormSubmission.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/TextResourceDecoderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/network/FormDataBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/FormDataBuilder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
philipj_slow
PTAL
6 years ago (2014-11-27 14:58:28 UTC) #2
philipj_slow
Sorry, this touches Source/platform, will go OWNERS-shopping elsewhere.
6 years ago (2014-11-27 14:59:04 UTC) #3
philipj_slow
Adam, can you PTAL?
6 years ago (2014-11-27 15:00:23 UTC) #5
philipj_slow
Arvid, can you PTAL at this as well? Adam's busy :)
6 years ago (2014-12-01 21:04:04 UTC) #7
philipj_slow
Sorry Mr. Arvidsson, I know your name is Erik :)
6 years ago (2014-12-01 21:05:38 UTC) #8
philipj_slow
drop FIXME
6 years ago (2014-12-02 10:08:01 UTC) #9
adamk
lgtm
6 years ago (2014-12-02 19:29:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761113003/20001
6 years ago (2014-12-02 20:24:51 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-02 20:26:49 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186333

Powered by Google App Engine
This is Rietveld 408576698