Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 760973002: Subzero: Improve malloc/free behavior. (Closed)

Created:
6 years ago by Jim Stichnoth
Modified:
6 years ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Improve malloc/free behavior. Use a bigger block size in the bump-pointer allocators, since we basically know up front that we'll need lots of memory. The 1MB value (versus the default of 4KB) was chosen somewhat arbitrarily, and succeeds in pretty much removing bump-pointer related mallocs from the profile. Pre-reserve the a priori known number of edges in getTerminatorEdges() to avoid vector resizing. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9d801a0123d352f3e94937954883ec5acaa842dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/IceCfg.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceGlobalContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceInst.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jim Stichnoth
6 years ago (2014-11-26 21:34:37 UTC) #2
Jim Stichnoth
Forgot to say that this appears to give 1-2% improvement in translation time.
6 years ago (2014-11-26 21:57:49 UTC) #3
Karl
lgtm
6 years ago (2014-11-26 22:04:56 UTC) #5
Jim Stichnoth
6 years ago (2014-11-26 22:11:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d801a0123d352f3e94937954883ec5acaa842dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698