Adds fake hardware video encoder.

media/cast/sender/video_sender_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/test/simple_test_tick_clock.h"
 #include "media/base/video_frame.h"
 #include "media/cast/cast_environment.h"
 #include "media/cast/logging/simple_event_subscriber.h"
 #include "media/cast/net/cast_transport_config.h"
 #include "media/cast/net/cast_transport_sender_impl.h"
 #include "media/cast/net/pacing/paced_sender.h"
 #include "media/cast/sender/video_frame_factory.h"
 #include "media/cast/sender/video_sender.h"
 #include "media/cast/test/fake_single_thread_task_runner.h"
-#include "media/cast/test/fake_video_encode_accelerator.h"
 #include "media/cast/test/utility/default_config.h"
 #include "media/cast/test/utility/video_utility.h"
+#include "media/video/fake_video_encode_accelerator.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace media {
 namespace cast {
 
 namespace {
 static const uint8 kPixelValue = 123;
 static const int kWidth = 320;
 static const int kHeight = 240;
@@ skipping 92 matching lines @@
                     create_vea_cb,
                     create_video_encode_mem_cb,
                     transport_sender,
                     base::Bind(&IgnorePlayoutDelayChanges)) {}
   using VideoSender::OnReceivedCastFeedback;
 };
 }  // namespace
 
 class VideoSenderTest : public ::testing::Test {
  protected:
-  VideoSenderTest() {
+  VideoSenderTest()
+      : stored_bitrates_(NULL) {
     testing_clock_ = new base::SimpleTestTickClock();
     testing_clock_->Advance(base::TimeTicks::Now() - base::TimeTicks());
     task_runner_ = new test::FakeSingleThreadTaskRunner(testing_clock_);
     cast_environment_ =
         new CastEnvironment(scoped_ptr<base::TickClock>(testing_clock_).Pass(),
                             task_runner_,
                             task_runner_,
                             task_runner_);
     last_pixel_value_ = kPixelValue;
     net::IPEndPoint dummy_endpoint;
@@ skipping 35 matching lines @@
     video_config.min_bitrate = 1000000;
     video_config.start_bitrate = 1000000;
     video_config.max_qp = 56;
     video_config.min_qp = 0;
     video_config.max_frame_rate = 30;
     video_config.max_number_of_video_buffers_used = 1;
     video_config.codec = CODEC_VIDEO_VP8;
     CastInitializationStatus status = STATUS_VIDEO_UNINITIALIZED;
 
     if (external) {
-      test::FakeVideoEncodeAccelerator* fake_vea =
-          new test::FakeVideoEncodeAccelerator(
-              task_runner_, &stored_bitrates_);
+      media::FakeVideoEncodeAccelerator* fake_vea =
+          new media::FakeVideoEncodeAccelerator(
+              task_runner_, std::vector<uint32>());
+      stored_bitrates_ = &fake_vea->stored_bitrates();
       fake_vea->SetWillInitializationSucceed(expect_init_success);
       scoped_ptr<VideoEncodeAccelerator> fake_vea_owner(fake_vea);
       video_sender_.reset(
           new PeerVideoSender(cast_environment_,
                               video_config,
                               base::Bind(&SaveInitializationStatus,
                                          &status),
                               base::Bind(&CreateVideoEncodeAccelerator,
                                          task_runner_,
                                          base::Passed(&fake_vea_owner)),
@@ skipping 39 matching lines @@
 
   void RunTasks(int during_ms) {
     task_runner_->Sleep(base::TimeDelta::FromMilliseconds(during_ms));
   }
 
   base::SimpleTestTickClock* testing_clock_;  // Owned by CastEnvironment.
   TestPacketSender transport_;
   scoped_ptr<CastTransportSenderImpl> transport_sender_;
   scoped_refptr<test::FakeSingleThreadTaskRunner> task_runner_;
   scoped_ptr<PeerVideoSender> video_sender_;
-  std::vector<uint32> stored_bitrates_;
+  const std::vector<uint32>* stored_bitrates_;

[wuchengli, 2014/12/09 14:29:25]

This is not very good because it is a part of PeerVideoSender. Also, I think
it's better to use googlemock EXPECT_CALL to count the number of method call. We
can have a mock class to inherit from FakeVEA. But there's no need to fix it in
this CL.

[hellner1, 2014/12/10 22:38:59]

Agree. No action then as changing this would bloat the cl.

   scoped_refptr<CastEnvironment> cast_environment_;
   int last_pixel_value_;
   base::TimeTicks first_frame_timestamp_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoSenderTest);
 };
 
 TEST_F(VideoSenderTest, BuiltInEncoder) {
   EXPECT_EQ(STATUS_VIDEO_INITIALIZED, InitEncoder(false, true));
   scoped_refptr<media::VideoFrame> video_frame = GetNewVideoFrame();
@@ skipping 14 matching lines @@
   const base::TimeTicks reference_time = testing_clock_->NowTicks();
   video_sender_->InsertRawVideoFrame(video_frame, reference_time);
   task_runner_->RunTasks();
   video_sender_->InsertRawVideoFrame(video_frame, reference_time);
   task_runner_->RunTasks();
   video_sender_->InsertRawVideoFrame(video_frame, reference_time);
   task_runner_->RunTasks();
 
   // Fixed bitrate is used for external encoder. Bitrate is only once
   // to the encoder.
-  EXPECT_EQ(1u, stored_bitrates_.size());
+  EXPECT_EQ(1u, stored_bitrates_->size());
   video_sender_.reset(NULL);
   task_runner_->RunTasks();
 }
 
 TEST_F(VideoSenderTest, ExternalEncoderInitFails) {
   EXPECT_EQ(STATUS_HW_VIDEO_ENCODER_NOT_SUPPORTED,
             InitEncoder(true, false));
   video_sender_.reset(NULL);
   task_runner_->RunTasks();
 }
@@ skipping 237 matching lines @@
   EXPECT_EQ(0, transport_.number_of_rtp_packets());
 }
 
 TEST_F(VideoSenderTest, CheckVideoFrameFactoryIsNull) {
   EXPECT_EQ(STATUS_VIDEO_INITIALIZED, InitEncoder(false, true));
   EXPECT_EQ(nullptr, video_sender_->CreateVideoFrameFactory().get());
 }
 
 }  // namespace cast
 }  // namespace media