Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 760943002: Ensure V8 snapshot files are present when chromoting_integration_tests runs. (Closed)

Created:
6 years ago by baixo
Modified:
6 years ago
Reviewers:
rmcilroy, anandc, baixo1, Jamie
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ensure natives_blob.bin and snapshot_blob.bin are present when running chromoting_integration_tests with isolate.py. BUG=421063, 436892 Committed: https://crrev.com/eaf6a0379031a3af5e86812a2e9ce125746278e1 Cr-Commit-Position: refs/heads/master@{#305945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M testing/chromoting/chromoting_integration_tests.isolate View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760943002/1
6 years ago (2014-11-26 19:36:16 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-11-26 19:36:17 UTC) #4
baixo1
+anandc and rmcilroy
6 years ago (2014-11-26 19:37:19 UTC) #6
anandc
This LGTM. However, I don't have committer privileges. I tested this patch locally, and it ...
6 years ago (2014-11-27 00:29:29 UTC) #8
Jamie
lgtm
6 years ago (2014-11-27 00:34:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760943002/1
6 years ago (2014-11-27 00:35:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-27 02:12:15 UTC) #12
commit-bot: I haz the power
6 years ago (2014-11-27 02:12:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eaf6a0379031a3af5e86812a2e9ce125746278e1
Cr-Commit-Position: refs/heads/master@{#305945}

Powered by Google App Engine
This is Rietveld 408576698