Rewrite Google Code http URLs with https on git svn dcommit.

Rewrite Google Code http URLs with https on git svn dcommit.

This fix is created to avoid having to rebuild all the WebRTC
Git mirrors since they're configured to sync with the http URL
instead of https (resulting in git-svn-id Git footers with the
http URL in the commit messages). Without rewriting this, it is
not possible to commit to SVN since Google code disallows committing
to a http URL.

BUG=412012
TEST=Created a CL using a Git repo like this (both before and after landing https://webrtc-codereview.appspot.com/32569004):
git clone https://chromium.googlesource.com/external/webrtc.git
cd webrtc
git auto-svn
git checkout master
git checkout -b test
(edit whitespace change)
git commit -am "Whitespace edit
git cl upload --bypass-hooks"
git cl dcommit

R=agable@chromium.org, machenbach@chromium.org, mmoss@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293171

[kjellander_chromium, 2014-11-29 17:08:53]

kjellander@chromium.org changed reviewers:
+ agable@chromium.org, mmoss@google.com

[kjellander_chromium, 2014-11-29 17:08:54]

As I now have reverted https://codereview.chromium.org/745473003/ (it doesn't do
any good at all, actually), I think this is the way to go to allow committing to
SVN for Git mirrors that have mirroring setup to the http URL instead of https.

[Michael Achenbach, 2014-11-30 14:32:29]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2014-11-30 14:32:29]

Basically (non-owner) lgtm. How difficult is it to add this feature to a test?

https://codereview.chromium.org/760903004/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/760903004/diff/1/git_cl.py#newcode2115
git_cl.py:2115: _, output = RunGitWithCode(['svn', 'dcommit',
You could make this even less intrusive by structuring it as follows:

args = [...]
if need to set https for googlecode:
  ...
  args += ['--commit-url=%s' % remote_url]
_, output = RunGitWithCode(args)

[Michael Achenbach, 2014-11-30 14:36:55]

Another idea: Instead of having an extra call to git svn info on every git cl
dcommit, you could also add a variable to codereview.settings that instructs git
cl dcommit to add https.

[kjellander_chromium, 2014-12-01 09:11:51]

> How difficult is it to add this feature to a test?

I had a look on how hard it would be but it seems a bit messy with the mocks.
Since it's a minor change that is now only applied if a codereview.settings flag
is set to true, I hope it's fine to leave it without a dedicated test.

> Another idea: Instead of having an extra call to git svn > info on every git
cl
> dcommit, you could also add a variable to 
> codereview.settings that instructs git
> cl dcommit to add https.

Great idea. Now implemented in PS#2.

https://codereview.chromium.org/760903004/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/760903004/diff/1/git_cl.py#newcode2115
git_cl.py:2115: _, output = RunGitWithCode(['svn', 'dcommit',
On 2014/11/30 14:32:29, Michael Achenbach wrote:
> You could make this even less intrusive by structuring it as follows:
> 
> args = [...]
> if need to set https for googlecode:
>   ...
>   args += ['--commit-url=%s' % remote_url]
> _, output = RunGitWithCode(args)

Great suggestion. I did this in PS#2.

[Michael Achenbach, 2014-12-01 09:43:43]

(still non-owner) lgtm with nits:

https://codereview.chromium.org/760903004/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/760903004/diff/20001/git_cl.py#newcode287
git_cl.py:287: self.forceHttpsCommitUrl = None
nit: noCamelCaseVariables

https://codereview.chromium.org/760903004/diff/20001/git_cl.py#newcode2124
git_cl.py:2124: # Allow forcing https commit URLs for some projects that doesn't
allow
nit: projects that don't

[kjellander_chromium, 2014-12-01 10:15:49]

Fixed the style violation.

https://codereview.chromium.org/760903004/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/760903004/diff/20001/git_cl.py#newcode287
git_cl.py:287: self.forceHttpsCommitUrl = None
On 2014/12/01 09:43:43, Michael Achenbach wrote:
> nit: noCamelCaseVariables

Oops. Done.

https://codereview.chromium.org/760903004/diff/20001/git_cl.py#newcode2124
git_cl.py:2124: # Allow forcing https commit URLs for some projects that doesn't
allow
On 2014/12/01 09:43:43, Michael Achenbach wrote:
> nit: projects that don't

Done.

[Michael Moss, 2014-12-01 18:09:34]

mmoss@chromium.org changed reviewers:
+ mmoss@chromium.org

[Michael Moss, 2014-12-01 18:09:34]

lgtm

[agable, 2014-12-01 21:33:24]

lgtm

[kjellander_chromium, 2014-12-02 06:56:11]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2014-12-02 06:57:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/760903004/40001

[commit-bot: I haz the power, 2014-12-02 06:59:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-02 06:59:03]

Presubmit check for 760903004-40001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (110 files) (61.91s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module fix_encoding
E:232, 0: Slice index is not an int, None, or instance with __index__
(invalid-slice-index)
************* Module gclient_scm
E:301,18: No value for argument 'print_func' in constructor call
(no-value-for-parameter)
E:1191,18: No value for argument 'print_func' in constructor call
(no-value-for-parameter)


post-dcommit-hook-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/post-dcommit-hook-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
Using 50% similarity for rename/copy detection. Override with --similarity.
Description:
dcommit
TESTING: post-cl-dcommit hook executed
FAILURE: post-cl-dcommit hook executed


Presubmit checks took 114.9s to calculate.

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[kjellander_chromium, 2014-12-02 07:34:53]

Committed patchset #3 (id:40001) manually as 293171.