Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 760883002: Add interceptor support for symbols (Closed)

Created:
6 years ago by dcarney
Modified:
6 years ago
Reviewers:
rossberg
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Add interceptor support for symbols a revival of https://codereview.chromium.org/467013003 R=rossberg@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -368 lines) Patch
M include/v8.h View 1 2 4 chunks +74 lines, -0 lines 0 comments Download
M samples/process.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M src/api.cc View 1 2 4 chunks +32 lines, -11 lines 0 comments Download
M src/arguments.h View 1 chunk +16 lines, -31 lines 0 comments Download
M src/elements.h View 1 chunk +6 lines, -9 lines 0 comments Download
M src/elements.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/objects.h View 3 chunks +12 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 3 11 chunks +49 lines, -52 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M test/cctest/test-accessors.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 114 chunks +335 lines, -206 lines 0 comments Download
M test/cctest/test-debug.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M test/cctest/test-decls.cc View 1 12 chunks +19 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcarney
ptal - this is just a rebase of the cl in the description with the ...
6 years ago (2014-11-26 14:56:24 UTC) #2
rossberg
LGTM (mostly rubber-stamped), with one comment. https://codereview.chromium.org/760883002/diff/20001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/760883002/diff/20001/include/v8.h#newcode3861 include/v8.h:3861: GenericNamedPropertyGetterCallback getter_; Nit: ...
6 years ago (2014-11-26 15:03:28 UTC) #3
dcarney
https://codereview.chromium.org/760883002/diff/20001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/760883002/diff/20001/include/v8.h#newcode3861 include/v8.h:3861: GenericNamedPropertyGetterCallback getter_; On 2014/11/26 15:03:27, rossberg wrote: > Nit: ...
6 years ago (2014-11-26 15:26:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760883002/40001
6 years ago (2014-11-26 15:27:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/1466)
6 years ago (2014-11-26 15:45:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760883002/60001
6 years ago (2014-11-27 09:51:14 UTC) #10
commit-bot: I haz the power
6 years ago (2014-11-27 10:21:39 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001)

Powered by Google App Engine
This is Rietveld 408576698