Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: ui/file_manager/video_player/js/cast/cast_video_element.js

Issue 760853003: Adds histograms for casting feature of Video Player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed the comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/metrics/histograms/histograms.xml ('k') | ui/file_manager/video_player/js/cast/caster.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/video_player/js/cast/cast_video_element.js
diff --git a/ui/file_manager/video_player/js/cast/cast_video_element.js b/ui/file_manager/video_player/js/cast/cast_video_element.js
index a2ffb3904438a2246531ab8e510810771b2bd78a..c3559fc05e699078101851847cd5734694a17ca7 100644
--- a/ui/file_manager/video_player/js/cast/cast_video_element.js
+++ b/ui/file_manager/video_player/js/cast/cast_video_element.js
@@ -227,6 +227,8 @@ CastVideoElement.prototype = {
if (this.castMedia_.playerState ===
chrome.cast.media.PlayerState.PLAYING &&
!this.pauseInProgress_) {
+ metrics.recordCastedVideoLength(this.currentMediaDuration_);
fukino 2014/12/10 08:01:47 It seems that the code here is for avoiding sendin
yoshiki 2014/12/10 09:33:19 Sorry, I added it the wrong place. Fixed.
fukino 2014/12/10 10:16:42 IIRC, when a user repeat PAUSE->PLAY->PAUSE->PLAY,
fukino 2014/12/10 12:18:31 It looks OK to record here, given that covering ca
+
this.playInProgress_ = false;
return;
}
« no previous file with comments | « tools/metrics/histograms/histograms.xml ('k') | ui/file_manager/video_player/js/cast/caster.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698