Introduce Stream::flush [2/2 chromium]

Introduce Stream::flush [2/2 chromium]

There is no way to flush the buffer in the stream.
This cl introduces Stream::flush method.
We can flush the buffer in the browser process using this method from blink.

We will use this method when we send the data from the ServiceWorker to the browser process progressively.

1/2 blink: https://codereview.chromium.org/747323007/
2/2 chromium: https://codereview.chromium.org/760823002/

BUG=436424
Committed: https://crrev.com/c93d25b4d2cb0981bfc1723bc401ff23c9302e58
Cr-Commit-Position: refs/heads/master@{#307684}

[horo, 2014-11-26 02:07:11]

Patchset #1 (id:1) has been deleted

[horo, 2014-11-26 02:09:47]

horo@chromium.org changed reviewers:
+ tyoshino@chromium.org

[horo, 2014-11-26 02:09:47]

tyoshino@
Could you please review?

[tyoshino (SeeGerritForStatus), 2014-11-26 05:59:49]

lgtm

https://codereview.chromium.org/760823002/diff/20001/content/browser/streams/...
File content/browser/streams/stream.h (right):

https://codereview.chromium.org/760823002/diff/20001/content/browser/streams/...
content/browser/streams/stream.h:71: // Flush contents buffered in the stream to
the corresponding reader.
Flushes

https://codereview.chromium.org/760823002/diff/20001/content/browser/streams/...
File content/browser/streams/stream_unittest.cc (right):

https://codereview.chromium.org/760823002/diff/20001/content/browser/streams/...
content/browser/streams/stream_unittest.cc:315: // called
period

[horo, 2014-11-26 06:06:29]

https://codereview.chromium.org/760823002/diff/20001/content/browser/streams/...
File content/browser/streams/stream.h (right):

https://codereview.chromium.org/760823002/diff/20001/content/browser/streams/...
content/browser/streams/stream.h:71: // Flush contents buffered in the stream to
the corresponding reader.
On 2014/11/26 05:59:49, tyoshino wrote:
> Flushes

Done.

https://codereview.chromium.org/760823002/diff/20001/content/browser/streams/...
File content/browser/streams/stream_unittest.cc (right):

https://codereview.chromium.org/760823002/diff/20001/content/browser/streams/...
content/browser/streams/stream_unittest.cc:315: // called
On 2014/11/26 05:59:49, tyoshino wrote:
> period

Done.

[horo, 2014-11-26 06:07:06]

horo@chromium.org changed reviewers:
+ zork@chromium.org

[horo, 2014-11-26 06:07:06]

zork@
Could you please review content/browser/streams/stream.*?

[horo, 2014-11-26 06:07:26]

horo@chromium.org changed reviewers:
+ nhiroki@chromium.org

[horo, 2014-11-26 06:07:26]

nhiroki@
Could you please review content/browser/fileapi/fileapi_message_filter.*?

[nhiroki, 2014-11-26 06:13:43]

LGTM for fileapi_message_filter.*

[horo, 2014-12-02 10:51:09]

zork@
Ping?

[Zachary Kuznia, 2014-12-02 14:44:40]

On 2014/12/02 10:51:09, horo(ooo -Dec.3) wrote:
> zork@
> Ping?

c/b/streams/* LGTM

[horo, 2014-12-04 06:26:14]

horo@chromium.org changed reviewers:
+ jochen@chromium.org

[horo, 2014-12-04 06:26:15]

jochen@
Could you please review content/child/webblobregistry_impl.* and
content/test/mock_webblob_registry_impl.*?

[horo, 2014-12-04 06:26:44]

horo@chromium.org changed reviewers:
+ mkwst@chromium.org

[horo, 2014-12-04 06:26:45]

mkwst@
Could you please review content/common/fileapi/webblob_messages.h?

[Mike West, 2014-12-04 13:38:13]

IPC LGTM.

[jochen (gone - plz use gerrit), 2014-12-08 12:06:41]

https://codereview.chromium.org/760823002/diff/40001/content/browser/fileapi/...
File content/browser/fileapi/fileapi_message_filter.cc (right):

https://codereview.chromium.org/760823002/diff/40001/content/browser/fileapi/...
content/browser/fileapi/fileapi_message_filter.cc:660: if (stream.get())
when can this happen? Should we kill the renderer if this happens?

[horo, 2014-12-09 02:28:51]

https://codereview.chromium.org/760823002/diff/40001/content/browser/fileapi/...
File content/browser/fileapi/fileapi_message_filter.cc (right):

https://codereview.chromium.org/760823002/diff/40001/content/browser/fileapi/...
content/browser/fileapi/fileapi_message_filter.cc:660: if (stream.get())
On 2014/12/08 12:06:41, jochen (slow) wrote:
> when can this happen? Should we kill the renderer if this happens?

When the reader of the stream stops reading, the stream will be unregistered
from the stream registry by Stream::CloseHandle().
So we have to check the existence of the stream.

[jochen (gone - plz use gerrit), 2014-12-10 10:13:58]

lgtm

[horo, 2014-12-10 10:16:44]

The CQ bit was checked by horo@chromium.org

[horo, 2014-12-10 10:16:52]

Thank you!

[commit-bot: I haz the power, 2014-12-10 10:17:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/760823002/40001

[commit-bot: I haz the power, 2014-12-10 11:58:22]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2014-12-10 11:59:13]

Patchset 2 (id:??) landed as
https://crrev.com/c93d25b4d2cb0981bfc1723bc401ff23c9302e58
Cr-Commit-Position: refs/heads/master@{#307684}