Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 760793003: Push roll candidates based on candidate ref instead of lkgr. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Push roll candidates based on candidate ref instead of lkgr. This pushes v8 to the candidates branch based on the candidate ref, which is guaranteed to be the same for 8 hours. The candidate ref is maintained by this bot: http://build.chromium.org/p/client.v8/builders/Auto-roll%20-%20release%20process NOTRY=true BUG=chromium:431669 LOG=n

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M tools/push-to-trunk/auto_push.py View 4 chunks +9 lines, -10 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
PTAL. tandrii is my normal reviewer for v8-side scripts - but he is OOO.
6 years ago (2014-11-26 11:46:55 UTC) #2
Michael Achenbach
[+jkummerow]
6 years ago (2014-11-26 14:33:47 UTC) #4
Jakob Kummerow
lgtm
6 years ago (2014-11-26 15:20:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760793003/1
6 years ago (2014-11-26 15:23:32 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-26 15:23:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698