Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 760753005: Revert of Turn ChannelMojo on Mac and Linux (Closed)

Created:
6 years ago by Hajime Morrita
Modified:
6 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn ChannelMojo on Mac and Linux (patchset #5 id:80001 of https://codereview.chromium.org/664413003/) Reason for revert: Got a perf regression report. Reverting. Original issue's description: > Turn ChannelMojo on Mac and Linux > > I don't see any page_cycler regression locally so I'll try > to enable this on trunk as the nex step. > This change doesn't turn this on Windows to keep the scope of > possible trouble small. > > BUG=377980 > R=viettrungluu@chromium.org, darin@chromium.org > > Committed: https://crrev.com/45d3cbd888ea1f20145e0f1451a7920a62a6653d > Cr-Commit-Position: refs/heads/master@{#304949} TBR=darin@chromium.org,viettrungluu@chromium.org NOTREECHECKS=true NOTRY=true BUG=377980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Hajime Morrita
Created Revert of Turn ChannelMojo on Mac and Linux
6 years ago (2014-11-26 17:42:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760753005/1
6 years ago (2014-11-26 17:43:06 UTC) #2
commit-bot: I haz the power
6 years ago (2014-11-26 17:43:46 UTC) #4
Failed to apply patch for ipc/mojo/ipc_channel_mojo.cc:
While running git apply --index -3 -p1;
  error: patch failed: ipc/mojo/ipc_channel_mojo.cc:175
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: ipc/mojo/ipc_channel_mojo.cc: patch does not apply

Patch:       ipc/mojo/ipc_channel_mojo.cc
Index: ipc/mojo/ipc_channel_mojo.cc
diff --git a/ipc/mojo/ipc_channel_mojo.cc b/ipc/mojo/ipc_channel_mojo.cc
index
45cdc1aafd70f2d3da723663e84c14b5e4fab690..4051bb5c21a87c3ea49811a7f30cfaeea124018f
100644
--- a/ipc/mojo/ipc_channel_mojo.cc
+++ b/ipc/mojo/ipc_channel_mojo.cc
@@ -175,15 +175,8 @@
 
 // static
 bool ChannelMojo::ShouldBeUsed() {
-  // Being conservative, this is currently enabled only on Mac and
-  // Linux even though this should work on all platforms.
-  // TODO(morrita): Turn this on all platform and kill
-  // --enable-renderer-mojo-channel
-#if defined(OS_POSIX) && !defined(OS_ANDROID)
-  return true;
-#else
+  // TODO(morrita): Turn this on for a set of platforms.
   return false;
-#endif
 }
 
 // static

Powered by Google App Engine
This is Rietveld 408576698