Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 760703002: Fix "value possibly truncated" warnings on MSVC, net/base edition. (Closed)

Created:
6 years ago by Peter Kasting
Modified:
6 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix "value possibly truncated" warnings on MSVC, net/base edition. This also adjusts MapSystemError() to take a SystemErrorCode, which wasn't strictly necessary to remove a warning but seemed more accurate. BUG=81439 TEST=none Committed: https://crrev.com/32c741528d6be56f7c8ec712a744f673d1b4343e Cr-Commit-Position: refs/heads/master@{#305749}

Patch Set 1 #

Patch Set 2 : Fix compile #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M net/base/dns_util.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M net/base/elements_upload_data_stream.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/base/file_stream_context.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/base/file_stream_context.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/base/net_errors.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/base/net_errors_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_errors_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/network_change_notifier.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/upload_bytes_element_reader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/upload_file_element_reader.cc View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Peter Kasting
https://codereview.chromium.org/760703002/diff/20001/net/base/upload_file_element_reader.cc File net/base/upload_file_element_reader.cc (right): https://codereview.chromium.org/760703002/diff/20001/net/base/upload_file_element_reader.cc#newcode143 net/base/upload_file_element_reader.cc:143: callback.Run(static_cast<int>(result)); At first I wondered if this shouldn't mean ...
6 years ago (2014-11-25 21:42:08 UTC) #2
Ryan Hamilton
lgtm
6 years ago (2014-11-26 00:07:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760703002/20001
6 years ago (2014-11-26 00:13:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-26 01:04:09 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-26 01:05:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32c741528d6be56f7c8ec712a744f673d1b4343e
Cr-Commit-Position: refs/heads/master@{#305749}

Powered by Google App Engine
This is Rietveld 408576698