Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: tools/telemetry/telemetry/core/device_finder.py

Issue 760653002: Telemetry --device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: browser selection Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/device_finder.py
diff --git a/tools/telemetry/telemetry/core/device_finder.py b/tools/telemetry/telemetry/core/device_finder.py
new file mode 100644
index 0000000000000000000000000000000000000000..987e1e71415b6efb63273ecb6468061904e83b6e
--- /dev/null
+++ b/tools/telemetry/telemetry/core/device_finder.py
@@ -0,0 +1,43 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Finds devices that can be controlled by telemetry."""
+
+from telemetry.core.platform import android_device
+from telemetry.core.platform import cros_device
+from telemetry.core.backends.chrome import cros_browser_finder
+from telemetry.core.backends.chrome import ios_browser_finder
+from telemetry.core.backends.webdriver import webdriver_desktop_browser_finder
+
+OTHER_DEVICES_NAMES = [
+ 'desktop',
+ 'trybot'
+ ]
+
+
+def GetAllAvailableDeviceNames(options):
+ """Returns a list of available devices.
+
+ Android devices are special and each Android device has its own serial number.
+ cros, ios, and webdriver devices are available if we can find browsers for
+ them. desktop and trybot are always available.
+ """
+ device_names = ['android: ' + d.device_id
+ for d in android_device.GetAllDevices()]
+
+ browsers = ios_browser_finder.FindAllAvailableBrowsers(options)
+ if ios_browser_finder.FindAllAvailableBrowsers(options) != []:
+ device_names.append(browsers[0].device_id)
nednguyen 2015/01/07 18:18:10 I don't like this hack.
+
+ if ios_browser_finder.FindAllAvailableBrowsers(options) != []:
+ device_names.append('ios')
+
+ if webdriver_desktop_browser_finder.FindAllAvailableBrowsers(options) != []:
+ device_names.append('webdriver')
+
+ device_names.extend(OTHER_DEVICES_NAMES)
+
+ device_names.sort()
+
+ return device_names

Powered by Google App Engine
This is Rietveld 408576698