tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py - Issue 760653002: Telemetry --device

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

Issue 760653002: Telemetry --device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser selection Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py ('k') | tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py » ('j') | tools/telemetry/telemetry/core/browser_finder.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

index 2e240c9e43366425c1d6fbbf1c108e892c25729d..ed752ce789147c68087ad675b5086f6040f7d342 100644

--- a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

@@ -28,13 +28,14 @@ class PossibleTrybotBrowser(possible_browser.PossibleBrowser):

target_os = browser_type.split('-')[1]

self._buildername = '%s_perf_bisect' % browser_type.replace(

'trybot-', '').replace('-', '_')

- super(PossibleTrybotBrowser, self).__init__(browser_type, target_os, True)

+ super(PossibleTrybotBrowser, self).__init__(browser_type, target_os,

+ 'trybot', True)

def Create(self, finder_options):

raise NotImplementedError()

def SupportsOptions(self, finder_options):

- if (finder_options.android_device or

+ if ((finder_options.device and finder_options.device != 'trybot') or

finder_options.chrome_root or

finder_options.cros_remote or

finder_options.extensions_to_load or