tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py - Issue 760653002: Telemetry --device

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py

Issue 760653002: Telemetry --device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser selection Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py ('k') | tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py » ('j') | tools/telemetry/telemetry/core/browser_finder.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py

index 98b84da2124815dab7a037d0ea5a18dd61728f50..2420bc7b9215f3e8d2cf40d0e9753a6587cb4781 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py

@@ -24,7 +24,7 @@ class AndroidBrowserFinderTest(unittest.TestCase):

def testNoPlatformReturnsEmptyList(self):

fake_platform = None

possible_browsers = android_browser_finder._FindAllPossibleBrowsers(

- self.finder_options, fake_platform)

+ self.finder_options, fake_platform, None)

self.assertEqual([], possible_browsers)

def testCanLaunchAlwaysTrueReturnsAll(self):

@@ -32,7 +32,7 @@ class AndroidBrowserFinderTest(unittest.TestCase):

expected_types = set(

android_browser_finder.FindAllBrowserTypes(self.finder_options))

possible_browsers = android_browser_finder._FindAllPossibleBrowsers(

- self.finder_options, fake_platform)

+ self.finder_options, fake_platform, None)

self.assertEqual(

expected_types,

set([b.browser_type for b in possible_browsers]))