tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py - Issue 760653002: Telemetry --device

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py

Issue 760653002: Telemetry --device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/platform/device.py ('K') | « tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py ('k') | tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py » ('j') | tools/telemetry/telemetry/core/platform/webdriver_desktop_device.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py

index 0fc6f3382fc942a8aaa52c8759b354736d0ddd18..f853d42cffe16d92d0fd2449895fedfcae2e4258 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py

@@ -7,7 +7,7 @@ import subprocess

import threading

from telemetry.core import util

-from telemetry.core.backends.chrome import android_browser_finder

+from telemetry.core.platform import android_device

from telemetry.core.platform import profiler

util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'android')

@@ -40,7 +40,7 @@ class JavaHeapProfiler(profiler.Profiler):

@classmethod

def is_supported(cls, browser_type):

if browser_type == 'any':

- return android_browser_finder.CanFindAvailableBrowsers()

+ return android_device.CanFindAvailableBrowsers()

return browser_type.startswith('android')

def CollectProfile(self):