tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py - Issue 760653002: Telemetry --device

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

Issue 760653002: Telemetry --device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py ('k') | tools/telemetry/telemetry/core/browser_options.py » ('j') | tools/telemetry/telemetry/core/browser_options.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

index a31593ce10199dfc989c745f97ab26ed654392cd..d27d96017581f5ff865b5262c3733d3601e2b0e3 100644

--- a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

@@ -34,7 +34,7 @@ class PossibleTrybotBrowser(possible_browser.PossibleBrowser):

raise NotImplementedError()

def SupportsOptions(self, finder_options):

- if (finder_options.android_device or

+ if (finder_options.device or

finder_options.chrome_root or

finder_options.cros_remote or

finder_options.extensions_to_load or