tools/telemetry/telemetry/core/platform/device.py - Issue 760653002: Telemetry --device

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/telemetry/core/platform/device.py

Issue 760653002: Telemetry --device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5	5

6 class Device(object):	6 class Device(object):

7 """ A base class of devices.	7 """ A base class of devices.

8 A device instance contains all the necessary information for constructing	8 A device instance contains all the necessary information for constructing

9 a platform backend object for remote platforms.	9 a platform backend object for remote platforms.

10	10

(...skipping 12 matching lines...) Expand all Loading...
23 def name(self):	23 def name(self):

24 return self._name	24 return self._name

25	25

26 @property	26 @property

27 def guid(self):	27 def guid(self):

28 return self._guid	28 return self._guid

29	29

30 @classmethod	30 @classmethod

31 def GetAllConnectedDevices(cls):	31 def GetAllConnectedDevices(cls):

32 raise NotImplementedError()	32 raise NotImplementedError()

	33

	34 def FindAllAvailableBrowsers(self, options):
	nednguyen 2014/12/04 02:48:34 Why is this is a Device method? Device represents Why is this is a Device method? Device represents the identity of physical device, it's not the API for inspecting or controlling the it, which is what platform is for. I rather keep this API minimal.
	35 raise NotImplementedError()

OLD	NEW