Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Unified Diff: content/public/browser/content_browser_client.h

Issue 76063007: Clean up RenderViewHostManager swapping logic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index 0a4928cebcee0768947ea0c5c3b25fa41e1c3556..bd3dc81f37444958ad749ebd8deb76947d8581c0 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -240,11 +240,14 @@ class CONTENT_EXPORT ContentBrowserClient {
virtual void SiteInstanceDeleting(SiteInstance* site_instance) {}
// Returns true if for the navigation from |current_url| to |new_url|
- // in |site_instance|, the process should be swapped (even if we are in a
- // process model that doesn't usually swap).
- virtual bool ShouldSwapProcessesForNavigation(SiteInstance* site_instance,
- const GURL& current_url,
- const GURL& new_url);
+ // in |site_instance|, a new SiteInstance and BrowsingInstance should be
+ // created (even if we are in a process model that doesn't usually swap.)
+ // This forces a process swap and severs script connections with existing
+ // tabs.
+ virtual bool ShouldSwapBrowsingInstancesForNavigation(
+ SiteInstance* site_instance,
+ const GURL& current_url,
+ const GURL& new_url);
// Returns true if the given navigation redirect should cause a renderer
// process swap.
« no previous file with comments | « content/browser/frame_host/render_view_host_manager_unittest.cc ('k') | content/public/browser/content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698