Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 760603002: Allow SVGPathStringSource to be allocated on the stack (Closed)

Created:
6 years ago by fs
Modified:
6 years ago
CC:
blink-reviews, krit, ed+blinkwatch_opera.com, fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Project:
blink
Visibility:
Public.

Description

Allow SVGPathStringSource to be allocated on the stack Neither of its two users require it to be heap-allocated. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M Source/core/svg/SVGPathStringSource.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/svg/SVGPathUtilities.cpp View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fs
Followup to https://codereview.chromium.org/734053005/
6 years ago (2014-11-25 17:35:32 UTC) #2
fs
Yo!
6 years ago (2014-11-26 18:19:53 UTC) #3
kouhei (in TOK)
lgtm if oilpan bots pass. SVGPathSource is a GarbageCollected.
6 years ago (2014-11-26 18:22:45 UTC) #4
f(malita)
LGTM. On 2014/11/26 18:19:53, fs wrote: > Yo! Sorry - I'm supper slow these days, ...
6 years ago (2014-11-26 18:25:03 UTC) #5
pdr.
Oilpans are happy. Pdrs are happy. LGTM
6 years ago (2014-11-26 23:23:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760603002/1
6 years ago (2014-11-26 23:24:32 UTC) #9
commit-bot: I haz the power
6 years ago (2014-11-26 23:26:10 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186069

Powered by Google App Engine
This is Rietveld 408576698