Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: src/gpu/gl/GrGLProgramDesc.h

Issue 760593005: Update effect key for descriptor to not record offsets. (Closed) Base URL: https://skia.googlesource.com/skia.git@keyBuilder
Patch Set: Review fixes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/gl/GrGLProgramDesc.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/GrGLProgramDesc.h
diff --git a/src/gpu/gl/GrGLProgramDesc.h b/src/gpu/gl/GrGLProgramDesc.h
index 8b032e099ce0998f8b2adf9b7c5bf0f56a3381c8..b53daeb444c3f52893c0ae786194ce88307bbc46 100644
--- a/src/gpu/gl/GrGLProgramDesc.h
+++ b/src/gpu/gl/GrGLProgramDesc.h
@@ -29,16 +29,16 @@ public:
// 1. uint32_t for total key length.
// 2. uint32_t for a checksum.
// 3. Header struct defined above.
- // 4. An array of offsets to effect keys and their sizes (see 5). uint16_t for each
- // offset and size.
- // 5. per-effect keys. Each effect's key is a variable length array of uint32_t.
+ // 4. Backend-specific information including per-processor keys and their key lengths.
+ // Each processor's key is a variable length array of uint32_t.
enum {
// Part 3.
kHeaderOffset = GrProgramDesc::kHeaderOffset,
kHeaderSize = SkAlign4(sizeof(GLKeyHeader)),
// Part 4.
- // This is the offset in the overall key to the array of per-effect offset,length pairs.
- kProcessorKeyOffsetsAndLengthOffset = kHeaderOffset + kHeaderSize,
+ // This is the offset into the backenend specific part of the key, which includes
+ // per-processor keys.
+ kProcessorKeysOffset = kHeaderOffset + kHeaderSize,
};
/**
@@ -67,14 +67,6 @@ public:
static const GLKeyHeader& GetHeader(const GrProgramDesc& desc) {
return *desc.atOffset<GLKeyHeader, kHeaderOffset>();
}
-
-private:
- template <class ProcessorKeyBuilder>
- static bool BuildStagedProcessorKey(const typename ProcessorKeyBuilder::StagedProcessor& stage,
- const GrGLCaps& caps,
- bool requiresLocalCoordAttrib,
- GrProgramDesc* desc,
- int* offsetAndSizeIndex);
};
#endif
« no previous file with comments | « no previous file | src/gpu/gl/GrGLProgramDesc.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698