Add PIXEL_FORMAT_NV12 into VideoPixelFormat

content/browser/renderer_host/media/video_capture_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Unit test for VideoCaptureController.
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 614 matching lines @@
   Mock::VerifyAndClearExpectations(client_a_.get());
 
   // Second client connects after the error state. It also should get told of
   // the error.
   EXPECT_CALL(*client_b_, DoError(route_id)).Times(1);
   controller_->AddClient(
       route_id, client_b_.get(), base::kNullProcessHandle, 200, session_200);
   Mock::VerifyAndClearExpectations(client_b_.get());
 }
 
+// Exercise OnIncomingCapturedData() code path of VideoCaptureController

[kbalazs, 2014/12/04 17:00:30]

Instead of comment please make the name of the test meaningful enough. Something
like CaptureAllVideoFormat?

[zhaoze.zhou, 2014/12/04 19:01:42]

All Done.

+TEST_F(VideoCaptureControllerTest, OnIncomingCapturedData) {
+
+  for (int index = media::PIXEL_FORMAT_I420; index <= media::PIXEL_FORMAT_MAX;

[kbalazs, 2014/12/04 17:00:30]

I would jut assign 0 first, it doesn't matter which format is the first. And I
think you can use an enum directly as loop variable, no need to go from int to
enum.

+                                             index++) {
+    media::VideoPixelFormat format;
+    format = static_cast<media::VideoPixelFormat>(index);
+    media::VideoCaptureParams session_100;

[kbalazs, 2014/12/04 17:00:30]

100? Copy paste programming?

+    session_100.requested_format = media::VideoCaptureFormat(
+        gfx::Size(320, 240), 30, format);
+
+    gfx::Size capture_resolution(320,240);

[kbalazs, 2014/12/04 17:00:30]

 (320, 240)
      ^
      |
   SPACE!!!

+
+    // The device format needn't match the VideoCaptureParams (the camera can do
+    // what it wants). Pick something random.
+    media::VideoCaptureFormat device_format(
+        gfx::Size(10, 10), 25, media::PIXEL_FORMAT_RGB24);
+
+    const VideoCaptureControllerID client_a_route_1(0x99);

[kbalazs, 2014/12/04 17:00:30]

There is only one client, you can just name it client. Please get rid of fancy
variable names.

+
+    // add clients
+    controller_->AddClient(client_a_route_1,
+                           client_a_.get(),
+                           base::kNullProcessHandle,
+                           100,
+                           session_100);
+    ASSERT_EQ(1, controller_->GetClientCount());
+
+    // Now, simulate an incoming captured buffer from the capture device.
+    scoped_refptr<media::VideoCaptureDevice::Client::Buffer> buffer;
+    buffer =
+        device_->ReserveOutputBuffer(media::VideoFrame::I420,
+                                     capture_resolution);
+    ASSERT_TRUE(buffer.get());
+
+    // Captured a new video frame
+    device_->OnIncomingCapturedData(
+              (unsigned char*)buffer.get()->data(),

[kbalazs, 2014/12/04 17:00:30]

C-style cast? should be static_cast

+              buffer.get()->size(),
+              session_100.requested_format,
+              0,
+              base::TimeTicks());
+
+    base::RunLoop().RunUntilIdle();
+    Mock::VerifyAndClearExpectations(client_a_.get());
+  }
+}
+
 }  // namespace content