Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 760573003: Undo a68594234262 (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Undo a68594234262. The buffer sizing logic was correct to start with. I don’t know why I misread it. It should say “if this would resize to receive a large message, use the entire allocation rounded up to full page size, otherwise, only use the space expected for a message.” TEST=util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/50726ac8d03780784d1014a89f6290adc69135cc

Patch Set 1 #

Total comments: 1

Patch Set 2 : expected_request_size #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M util/mach/mach_message_server.cc View 1 2 1 chunk +5 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
6 years ago (2014-11-25 23:08:58 UTC) #2
Robert Sesek
https://codereview.chromium.org/760573003/diff/1/util/mach/mach_message_server.cc File util/mach/mach_message_server.cc (right): https://codereview.chromium.org/760573003/diff/1/util/mach/mach_message_server.cc#newcode113 util/mach/mach_message_server.cc:113: mach_msg_size_t max_request_size = interface->MachMessageServerRequestSize(); Maybe not calling this |max_request_size| ...
6 years ago (2014-12-01 21:03:53 UTC) #3
Mark Mentovai
expected_request_size?
6 years ago (2014-12-01 21:06:04 UTC) #4
Robert Sesek
Yeah, that's more clear. LGTM
6 years ago (2014-12-01 21:08:27 UTC) #5
Mark Mentovai
6 years ago (2014-12-01 21:12:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
50726ac8d03780784d1014a89f6290adc69135cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698