Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: media/mojo/interfaces/media_types.mojom

Issue 760523008: Switch from a DataPipe per DecoderBuffer to a single one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/interfaces/demuxer_stream.mojom ('k') | media/mojo/services/media_type_converters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/interfaces/media_types.mojom
diff --git a/media/mojo/interfaces/media_types.mojom b/media/mojo/interfaces/media_types.mojom
index 7ce78f64840ad3a2dddad1cc71e1b1586e555afa..1e7837541cef3af8d43cc0bb728a4730ad4c9fef 100644
--- a/media/mojo/interfaces/media_types.mojom
+++ b/media/mojo/interfaces/media_types.mojom
@@ -190,7 +190,8 @@ struct MediaDecoderBuffer {
int64 timestamp_usec;
int64 duration_usec;
- // The number of bytes in |data|.
+ // The number of bytes present in this buffer. The data is not serialized
+ // along with this structure and must be read from a separate DataPipe.
uint32 data_size;
// Indicates whether or not this buffer is a random access point.
@@ -210,10 +211,4 @@ struct MediaDecoderBuffer {
// Indicates this buffer is part of a splice around |splice_timestamp_usec|.
int64 splice_timestamp_usec;
-
- // The payload. Invalid handle indicates an end-of-stream (EOS) buffer.
- // TODO(tim): This currently results in allocating a new, largeish DataPipe
- // for each buffer. Remove this once framed data pipes exist, but using this
- // for now for prototyping audio.
- handle<data_pipe_consumer>? data;
};
« no previous file with comments | « media/mojo/interfaces/demuxer_stream.mojom ('k') | media/mojo/services/media_type_converters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698