Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: media/mojo/interfaces/demuxer_stream.mojom

Issue 760523008: Switch from a DataPipe per DecoderBuffer to a single one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Fix. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/interfaces/demuxer_stream.mojom
diff --git a/media/mojo/interfaces/demuxer_stream.mojom b/media/mojo/interfaces/demuxer_stream.mojom
index 3024942ff29eb288feab44f28ba81924c3d49fa0..b673b09d8df6eba12f632d9ef5cf9166c090ce73 100644
--- a/media/mojo/interfaces/demuxer_stream.mojom
+++ b/media/mojo/interfaces/demuxer_stream.mojom
@@ -30,9 +30,9 @@ interface DemuxerStream {
// When available, the callback will be invoked with a Status and |response|
// buffer. See media::DemuxerStream::ReadCB for explanation of fields.
//
- // TODO(tim): Remove this method in favor of initializing the
- // DemuxerStreamClient with a DataPipeConsumerHandle once we have a framed
- // DataPipe that we can serialize [|status| | response|]* over directly.
+ // TODO(dalecurtis): Remove this method in favor of serializing everything
+ // into the DataPipe given to OnStreamReady() once DataPipe supports framed
+ // data in a nicer fashion.
Read() => (Status status, MediaDecoderBuffer response);
};
@@ -40,11 +40,11 @@ interface DemuxerStreamClient {
// Informs the client that the stream is ready for reading. If |pipe| is
xhwang 2014/12/06 00:03:44 pipe muse be present now
DaleCurtis 2014/12/06 00:42:59 Done.
// present, it means the client should read
//
- // [ |DemuxerStream::Status| |MediaDecoderBuffer| ]
+ // [ |media::DecoderBuffer::data()| ]
//
// payloads from the DataPipe directly. If |pipe| is NULL, it means the
xhwang 2014/12/06 00:03:44 pipe cannot be null now.
DaleCurtis 2014/12/06 00:42:59 Done.
// client needs to use DemuxerStream::Read() directly to obtain buffers.
- OnStreamReady(handle<data_pipe_consumer>? pipe);
+ OnStreamReady(handle<data_pipe_consumer> pipe);
// A new AudioDecoderConfig is available. Will be sent by the DemuxerStream
// whenever a DemuxerStream::STATUS_CONFIG_CHANGED is observed (either

Powered by Google App Engine
This is Rietveld 408576698