Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 760523006: Add .dwarf2_addr_size directive to gas (Closed)

Created:
6 years ago by Derek Schuff
Modified:
6 years ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/nacl-binutils.git@master
Visibility:
Public.

Description

Add .dwarf2_addr_size directive to gas gas assumes that the address size used for DWARF debug info (and thus the line tables it generates from .loc directives) will always match the ELF class. However LLVM generates debug info that matches the actual address size (32 bit on x86-64 NaCl), which results in a mismatch between LLVM's debug info and gas' line tables. This CL adds a directive to gas to change the address size. R=mcgrathr@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3966 Committed: https://git.chromium.org/gitweb?p=native_client/nacl-binutils.git;a=commit;h=f009fc843ba7b9028f394725961bf899a172f45b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M gas/config/tc-i386.c View 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Derek Schuff
6 years ago (2014-11-25 22:02:41 UTC) #1
Roland McGrath
lgtm
6 years ago (2014-11-25 22:22:06 UTC) #2
Derek Schuff
6 years ago (2014-11-25 22:24:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f009fc843ba7b9028f394725961bf899a172f45b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698