Issue 760523004: [turbofan] Recognize rotate right.

Issue 760523004: [turbofan] Recognize rotate right. (Closed)

Created:
6 years ago by Rodolph Perfetta (ARM)

Modified:
6 years ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

[turbofan] Recognize rotate right. Extended the rotate left detection code. BUG=

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -68 lines)			Patch
M	src/compiler/machine-operator-reducer.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/machine-operator-reducer.cc	View	1	2 chunks	+60 lines, -62 lines	0 comments	Download
M	test/mjsunit/asm/word32ror.js	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	test/unittests/compiler/machine-operator-reducer-unittest.cc	View		2 chunks	+26 lines, -6 lines	0 comments	Download

Total messages: 9 (2 generated)

Rodolph Perfetta (ARM)

This doesn't address the "arm32 not matching because of & 1F" issue. This will be ...

6 years ago (2014-11-25 11:06:49 UTC) #1

Benedikt Meurer

Why move it to a separate method? How about moving the whole Word32Or case to ...

6 years ago (2014-11-25 12:01:44 UTC) #4

Rodolph Perfetta (ARM)

On 2014/11/25 12:01:44, Benedikt Meurer wrote: > Why move it to a separate method? How ...

6 years ago (2014-11-25 16:44:47 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760523004/20001

6 years ago (2014-11-26 11:22:02 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001)