Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: extensions/common/csp_validator.h

Issue 760513003: Only allow insecure object-src directives for whitelisted mime types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extensions-csp3
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | extensions/common/csp_validator.cc » ('j') | extensions/common/csp_validator.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_CSP_VALIDATOR_H_ 5 #ifndef EXTENSIONS_COMMON_CSP_VALIDATOR_H_
6 #define EXTENSIONS_COMMON_CSP_VALIDATOR_H_ 6 #define EXTENSIONS_COMMON_CSP_VALIDATOR_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "extensions/common/manifest.h" 10 #include "extensions/common/manifest.h"
11 11
12 namespace extensions { 12 namespace extensions {
13 13
14 namespace csp_validator { 14 namespace csp_validator {
15 15
16 // Checks whether the given |policy| is legal for use in the extension system. 16 // Checks whether the given |policy| is legal for use in the extension system.
17 // This check just ensures that the policy doesn't contain any characters that 17 // This check just ensures that the policy doesn't contain any characters that
18 // will cause problems when we transmit the policy in an HTTP header. 18 // will cause problems when we transmit the policy in an HTTP header.
19 bool ContentSecurityPolicyIsLegal(const std::string& policy); 19 bool ContentSecurityPolicyIsLegal(const std::string& policy);
20 20
21 // This specifies options for configuring which CSP directives are permitted in
22 // extensions.
23 enum Options {
24 OPTIONS_NONE = 0,
25 // Allows 'unsafe-eval' to be specified as a source in a directive.
26 OPTIONS_ALLOW_UNSAFE_EVAL = 1 << 0,
27 // Allow an object-src to be specified with any sources (i.e. it may contain
28 // wildcards or http sources). Specifying this requires the CSP to contain
29 // a plugin-types directive which restricts the plugins that can be loaded
30 // to those which are fully sandboxed.
31 OPTIONS_ALLOW_INSECURE_OBJECT_SRC = 1 << 1,
32 };
33
21 // Checks whether the given |policy| meets the minimum security requirements 34 // Checks whether the given |policy| meets the minimum security requirements
22 // for use in the extension system. 35 // for use in the extension system.
23 // 36 //
24 // Ideally, we would like to say that an XSS vulnerability in the extension 37 // Ideally, we would like to say that an XSS vulnerability in the extension
25 // should not be able to execute script, even in the precense of an active 38 // should not be able to execute script, even in the precense of an active
26 // network attacker. 39 // network attacker.
27 // 40 //
28 // However, we found that it broke too many deployed extensions to limit 41 // However, we found that it broke too many deployed extensions to limit
29 // 'unsafe-eval' in the script-src directive, so that is allowed as a special 42 // 'unsafe-eval' in the script-src directive, so that is allowed as a special
30 // case for extensions. Platform apps disallow it. 43 // case for extensions. Platform apps disallow it.
44 //
45 // |options| is a bitmask of Options.
31 bool ContentSecurityPolicyIsSecure( 46 bool ContentSecurityPolicyIsSecure(
32 const std::string& policy, Manifest::Type type); 47 const std::string& policy, int options);
33 48
34 // Checks whether the given |policy| enforces a unique origin sandbox as 49 // Checks whether the given |policy| enforces a unique origin sandbox as
35 // defined by http://www.whatwg.org/specs/web-apps/current-work/multipage/ 50 // defined by http://www.whatwg.org/specs/web-apps/current-work/multipage/
36 // the-iframe-element.html#attr-iframe-sandbox. The policy must have the 51 // the-iframe-element.html#attr-iframe-sandbox. The policy must have the
37 // "sandbox" directive, and the sandbox tokens must not include 52 // "sandbox" directive, and the sandbox tokens must not include
38 // "allow-same-origin". Additional restrictions may be imposed depending on 53 // "allow-same-origin". Additional restrictions may be imposed depending on
39 // |type|. 54 // |type|.
40 bool ContentSecurityPolicyIsSandboxed( 55 bool ContentSecurityPolicyIsSandboxed(
41 const std::string& policy, Manifest::Type type); 56 const std::string& policy, Manifest::Type type);
42 57
43 } // namespace csp_validator 58 } // namespace csp_validator
44 59
45 } // namespace extensions 60 } // namespace extensions
46 61
47 #endif // EXTENSIONS_COMMON_CSP_VALIDATOR_H_ 62 #endif // EXTENSIONS_COMMON_CSP_VALIDATOR_H_
OLDNEW
« no previous file with comments | « no previous file | extensions/common/csp_validator.cc » ('j') | extensions/common/csp_validator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698