Out of line CallbackBase's copy and assignment operators.

Out of line CallbackBase's copy and assignment operators.

This saved nearly 300KiB on a release build of Chrome.

BUG=436357
Committed: https://crrev.com/f883604e3ea3a0b9881dc5eb1e933fb66d914003
Cr-Commit-Position: refs/heads/master@{#305784}

[dcheng, 2014-11-25 10:07:19]

dcheng@chromium.org changed reviewers:
+ thakis@chromium.org

[dcheng, 2014-11-25 23:19:17]

WDYT? Is this worth committing with a landmine?
https://codereview.chromium.org/684033002/ would fix the dependency issues, but
I don't know when that will be committed =/

[Nico, 2014-11-25 23:21:53]

Can you ask on the other review (note to self:
https://codereview.chromium.org/684033002/) if they can land it?

https://codereview.chromium.org/760513002/diff/40001/base/callback_internal.cc
File base/callback_internal.cc (right):

https://codereview.chromium.org/760513002/diff/40001/base/callback_internal.c...
base/callback_internal.cc:12: CallbackBase::CallbackBase(const CallbackBase& c)
= default;
s/= default;/{}/, shorter, does the same thing, is understood by more people

[dcheng, 2014-11-25 23:24:15]

https://codereview.chromium.org/760513002/diff/40001/base/callback_internal.cc
File base/callback_internal.cc (right):

https://codereview.chromium.org/760513002/diff/40001/base/callback_internal.c...
base/callback_internal.cc:12: CallbackBase::CallbackBase(const CallbackBase& c)
= default;
On 2014/11/25 23:21:52, Nico wrote:
> s/= default;/{}/, shorter, does the same thing, is understood by more people

Err, that's not the same though, is it? This is a copy constructor, not a
default constructor.

[Nico, 2014-11-25 23:33:47]

lgtm then!

We'll see if this causes any performance issues due to the additional jump on
every callback creation.

https://codereview.chromium.org/760513002/diff/40001/base/callback_internal.cc
File base/callback_internal.cc (right):

https://codereview.chromium.org/760513002/diff/40001/base/callback_internal.c...
base/callback_internal.cc:12: CallbackBase::CallbackBase(const CallbackBase& c)
= default;
On 2014/11/25 23:24:15, dcheng wrote:
> On 2014/11/25 23:21:52, Nico wrote:
> > s/= default;/{}/, shorter, does the same thing, is understood by more people
> 
> Err, that's not the same though, is it? This is a copy constructor, not a
> default constructor.

Err, yes. I fail at reading.

[dcheng, 2014-11-26 03:16:56]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2014-11-26 03:16:57]

Sorry, it turns out I'm impatient.

[commit-bot: I haz the power, 2014-11-26 03:18:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/760513002/50001

[commit-bot: I haz the power, 2014-11-26 05:05:00]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2014-11-26 05:05:47]

Patchset 4 (id:??) landed as
https://crrev.com/f883604e3ea3a0b9881dc5eb1e933fb66d914003
Cr-Commit-Position: refs/heads/master@{#305784}