Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 760503002: Turn on stack use-after-return detection in non-official ASan builds. (Closed)

Created:
6 years ago by Alexander Potapenko
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Turn on stack use-after-return detection in non-official ASan builds. BUG=390117 R=scherkus@chromium.org TBR=earthdok@chromium.org,thakis@chromium.org Committed: https://crrev.com/136dc0bf75f9be7ae86c336005279b6dde4dee46 Cr-Commit-Position: refs/heads/master@{#306429}

Patch Set 1 #

Patch Set 2 : Don't detect UARs on Mac #

Patch Set 3 : Force local variables to be allocated on stack in ProcMapsTest.ReadProcMaps #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M base/debug/proc_maps_linux_unittest.cc View 1 2 3 4 2 chunks +20 lines, -10 lines 0 comments Download
M build/sanitizers/sanitizer_options.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760503002/20001
6 years ago (2014-12-02 10:01:18 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/14089)
6 years ago (2014-12-02 11:48:34 UTC) #5
Alexander Potapenko
+Andrew, whose code I touched. TBRing Nico for base/ ownership
6 years ago (2014-12-02 17:42:09 UTC) #7
earthdok
lgtm w/nit https://codereview.chromium.org/760503002/diff/60001/base/debug/proc_maps_linux_unittest.cc File base/debug/proc_maps_linux_unittest.cc (left): https://codereview.chromium.org/760503002/diff/60001/base/debug/proc_maps_linux_unittest.cc#oldcode193 base/debug/proc_maps_linux_unittest.cc:193: // mapped into memory. Use the address ...
6 years ago (2014-12-02 17:45:26 UTC) #8
Alexander Potapenko
https://codereview.chromium.org/760503002/diff/60001/base/debug/proc_maps_linux_unittest.cc File base/debug/proc_maps_linux_unittest.cc (left): https://codereview.chromium.org/760503002/diff/60001/base/debug/proc_maps_linux_unittest.cc#oldcode193 base/debug/proc_maps_linux_unittest.cc:193: // mapped into memory. Use the address of |proc_maps| ...
6 years ago (2014-12-02 17:52:06 UTC) #9
scherkus (not reviewing)
lgtm
6 years ago (2014-12-02 18:13:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760503002/70003
6 years ago (2014-12-02 18:21:11 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:70003)
6 years ago (2014-12-02 19:03:17 UTC) #13
Alexander Potapenko
On 2014/12/02 19:03:17, I haz the power (commit-bot) wrote: > Committed patchset #5 (id:70003) Looks ...
6 years ago (2014-12-02 19:04:35 UTC) #14
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/136dc0bf75f9be7ae86c336005279b6dde4dee46 Cr-Commit-Position: refs/heads/master@{#306429}
6 years ago (2014-12-02 19:04:59 UTC) #15
Alexander Potapenko
6 years ago (2014-12-03 16:21:45 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:70003) has been created in
https://codereview.chromium.org/774483004/ by glider@chromium.org.

The reason for reverting is: This broke some layout tests, see
http://crbug.com/438499.

Powered by Google App Engine
This is Rietveld 408576698