Issue 7605026: ARM: Support record write stubs for incremental marking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7605026: ARM: Support record write stubs for incremental marking. (Closed)

Created:
9 years, 4 months ago by Michael Starzinger

Modified:
9 years, 4 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

ARM: Support record write stubs for incremental marking. R=erik.corry@gmail.com BUG=v8:1456 Committed: http://code.google.com/p/v8/source/detail?r=8888

Patch Set 2 : Fix missing untagging in RecordWriteField. #

Total comments: 2

Patch Set 3 : Fix un-nop-ish nop instruction. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -15 lines)			Patch
M	src/arm/assembler-arm.h	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	src/arm/code-stubs-arm.h	View	1 2	5 chunks	+72 lines, -7 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1	1 chunk	+122 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/7605026/diff/3001/src/arm/code-stubs-arm.h File src/arm/code-stubs-arm.h (right): http://codereview.chromium.org/7605026/diff/3001/src/arm/code-stubs-arm.h#newcode413 src/arm/code-stubs-arm.h:413: masm->instr_at_put(pos, (masm->instr_at(pos) & ~(B27 | B25)) | You ...

9 years, 4 months ago (2011-08-11 07:35:21 UTC) #2

Michael Starzinger

9 years, 4 months ago (2011-08-11 07:48:17 UTC) #3

http://codereview.chromium.org/7605026/diff/3001/src/arm/code-stubs-arm.h
File src/arm/code-stubs-arm.h (right):

http://codereview.chromium.org/7605026/diff/3001/src/arm/code-stubs-arm.h#new...
src/arm/code-stubs-arm.h:413: masm->instr_at_put(pos, (masm->instr_at(pos) &
~(B27 | B25)) |
On 2011/08/11 07:35:21, Erik Corry wrote:
> You don't need to both zero out B25 and then set it again.
> As discussed offline we need the I version of the TST instruction so we can be
> sure that the last 12 bits of the instruction are free to use for an
immediate.

Done.